Can't save product attribute: Attribute code is invalid.

[hoangnm89]

Preconditions

1. Magento 2.1.6
2. php 5.6
3. mysql 5.6

Steps to reproduce

1. Create new product attribute:
   Title: physical specification - Weight (g)
   Attribute Code: specs_weight
2. Press Save and Continue Edit => successfully
3. Change Title of attribute to: Physical Specification - Weight (g) (uppercase: P and S)

Expected result

1. It should change title to new one: Physical Specification - Weight (g)

Actual result

It can't save and thrown: Attribute code "attr_physical_specification_weight_" is invalid. Please use only letters (a-z), numbers (0-9) or underscore(_) in this field, first character should be a letter.

here is some more attributes get same problem:
Speaker - Subwoofer Type ( Active / Passive / Wireless, Bulit-in )
Connectivity - ARC (Audio Return Channel)
Audio Feature - Bluetooth HI-FI Codec

[korostii]

This is probably a duplicate of #6770.

The underlying issue is that there's a hard-coded limit on the maximum allowed length of the attribute code. While I agree that the limit should be increased, the error message itself should also be changed.

[veloraven]

I'm closing this issue as a duplicate.
@korostii thank you for link to corresponding issue.

[korostii]

Sure, NP.
As far as I know, the limit went up to 60 on develop branch recently.

Still, it's a bit strange though that the automatic attribute code generation prevents you from having a longer label.

[abrittis]

I agree with korostii. Why is the attribute code uneditable, and there is a automatic generator that uses the label to generate an invalid one - thus limiting the ability to name the label.

Either:

1. Allow the user to generate their own code. System can give a uniqueness error length error as needed.
2. If the editor / system feels the need to generate a code (i.e. the user left it blank) - at least put proper logic to generate a valid code based on a valid label.