Core Colorpicker JS doesn't work with RequireJS

[PivitParkour94]

Preconditions

1. Magento 2.2.x
2. Mysql Ver 15.1 Distrib 10.2.15-MariaDB, for Linux (x86_64) using readline 5.1
3. PHP 7.0.30
4. RequireJS 2.1.11

Steps to reproduce

1. Create a javascript file that requires the colorpicker used in the core (under the product attribute Visual Swatch in the admin panel)

// Vendor_Module/js/this/custom/file
require([
    'jquery',
    'jquery/colorpicker/js/colorpicker',
], function ($) {
    'use strict';
    // do anything, the damage is done
    console.log("required the colorpicker. Be free!");

Expected result

1. Should see a message in the console that says "required the colorpicker. Be free!"
2. Can then customise the colorpicker as you would please.

Actual result

1. Console error "Uncaught Error: Mismatched anonymous define() module" talking about the colorpicker.

To solve it, simply add any random string ID to the definition of the colorpicker.
Example

// lib/web/jquery/colorpicker/js/colorpicker.js:10
define("mage/colorpicker", [
	"jquery",
], function ($) {

A quick workaround is to simply repackage the colorpicker into the module/theme you want to use, with it patched as described, but it would be awesome to have this patched in the core, with the correct naming convention etc.

Please let me know if any more details are required.

[magento-engcom-team]

Hi @PivitParkour94. Thank you for your report.
To help us process this issue please make sure that you provided the following information:

• Summary of the issue
• Information on your environment
• Steps to reproduce
• Expected and actual results

Please make sure that the issue is reproducible on the vanilla Magento instance following Steps to reproduce. To deploy vanilla Magento instance on our environment, please, add a comment to the issue:

@magento-engcom-team give me {$VERSION} instance

where {$VERSION} is version tags (starting from 2.2.0+) or develop branches (2.2-develop +).
For more details, please, review the Magento Contributor Assistant documentation.

@PivitParkour94 do you confirm that you was able to reproduce the issue on vanilla Magento instance following steps to reproduce?

• yes
• no

[PivitParkour94]

@magento-engcom-team give me 2.2.5 instance

[magento-engcom-team]

Hi @PivitParkour94. Thank you for your request. I'm working on Magento 2.2.5 instance for you

[magento-engcom-team]

Hi @PivitParkour94, here is your Magento instance.
Admin access: https://i-17008-2-2-5.engcom.dev.magento.com/admin
Login: admin Password: 123123q
Instance will be terminated in up to 3 hours.

[PivitParkour94]

This issue is a file bug, not a system config bug so I can't test it without ssh access or something, which I imagine is outside the possibilities of this automation.

Its super cool, but we'll probably have to get a human to look at this. I'll make a PR for the fix.

[PivitParkour94]

I should probably also say that you can't even bypass this by defining a path for the colorpicker in requirejs-config. The error is still being thrown without the string ID.