Backend Product Edit Page Loads Indefinitely - JavaScript Console Error: Uncaught TypeError: value is null (Firefox Only)

[nikoelgatito]

Preconditions and environment

• Magento Version 2.4.3-p3 (2.4.3+)
• The Magento_PageBuilder module is installed and enabled.
• The latest version of the Firefox browser is installed.

Steps to reproduce

1. Navigate to the backend product edit page using the Firefox browser.

Expected result

The backend product edit page loads normally.

Actual result

The backend product edit page loads indefinitely and the JavaScript error "Uncaught TypeError: value is null" is displayed in the console.

Important Note:
For some reason, this bug is not triggered if the developer tools/console is already open when opening the backend product edit page. In order to reproduce this issue, it is important to first open the backend product edit page and then open the developer console.

Additional information

Cause & Solution:

The issue is caused by the fact that the function passed when adding the 'required-entry' rule does not verify if the value variable is null before using it as an object in the validator-rules-mixin.js file. The error is triggered even if there is an object type verification before trying to access the object's properties, since the type of a null value is object in JavaScript.

File Path:
vendor/magento/module-page-builder/view/adminhtml/web/js/form/element/validator-rules-mixin.js

Simply adding && value !== null is enough to prevent this issue from occurring.

Please refer to the patch below for more details.

Git Diff Patch:

diff --git a/vendor/magento/module-page-builder/view/adminhtml/web/js/form/element/validator-rules-mixin.js b/vendor/magento/module-page-builder/view/adminhtml/web/js/form/element/validator-rules-mixin.js
--- a/vendor/magento/module-page-builder/view/adminhtml/web/js/form/element/validator-rules-mixin.js
+++ b/vendor/magento/module-page-builder/view/adminhtml/web/js/form/element/validator-rules-mixin.js
@@ -234,7 +234,7 @@
                 var allFilled;
 
                 // Validation only for margins and paddings
-                if (typeof value === 'object' && !!(value.padding || value.margin)) {
+                if (typeof value === 'object' && value !== null && !!(value.padding || value.margin)) {
                     allFilled = true;
 
                     _.flatten(_.map(value, _.values)).forEach(function (val) {`

After reviewing the latest version of the validator-rules-mixin.js file, it seems that this issue is still present, as the function still does not verify if the value variable could be null before attempting to access its properties.

Link to the Latest File Version:
https://github.com/magento/magento2-page-builder/blob/47efafdc662272dfea91c4abd1968e63f9aa38df/app/code/Magento/PageBuilder/view/adminhtml/web/js/form/element/validator-rules-mixin.js#L237

Workaround:

Use another browser.

Release note

No response

Triage and priority

• Severity: S0 - Affects critical data or functionality and leaves users without workaround.
• Severity: S1 - Affects critical data or functionality and forces users to employ a workaround.
• Severity: S2 - Affects non-critical data or functionality and forces users to employ a workaround.
• Severity: S3 - Affects non-critical data or functionality and does not force users to employ a workaround.
• Severity: S4 - Affects aesthetics, professional look and feel, “quality” or “usability”.

[m2-assistant]

Hi @nikoelgatito. Thank you for your report.
To speed up processing of this issue, make sure that the issue is reproducible on the vanilla Magento instance following Steps to reproduce. To deploy vanilla Magento instance on our environment, Add a comment to the issue:

• @magento give me 2.4-develop instance - upcoming 2.4.x release
• For more details, review the Magento Contributor Assistant documentation.
• Add a comment to assign the issue: @magento I am working on this
• To learn more about issue processing workflow, refer to the Code Contributions.

---

Join Magento Community Engineering Slack and ask your questions in #github channel.
⚠️ According to the Magento Contribution requirements, all issues must go through the Community Contributions Triage process. Community Contributions Triage is a public meeting.
🕙 You can find the schedule on the Magento Community Calendar page.
📞 The triage of issues happens in the queue order. If you want to speed up the delivery of your contribution, join the Community Contributions Triage session to discuss the appropriate ticket.

[nikoelgatito]

@magento give me 2.4-develop instance

[magento-deployment-service]

Hi @nikoelgatito. Thank you for your request. I'm working on Magento instance for you.

[magento-deployment-service]

Hi @nikoelgatito, here is your Magento Instance: https://bac22ece0efb918dadd4d3b2fbc30015.instances.magento-community.engineering
Admin access: https://bac22ece0efb918dadd4d3b2fbc30015.instances.magento-community.engineering/admin_f362
Login: e6ad6fb5
Password: 26fdd8eeccb2

[nikoelgatito]

After testing on the 2.4-develop instance provided on the same Firefox browser version, it seems that this issue cannot simply be reproduced on a vanilla Magento instance. However, since simply passing a null value to the 'required-entry' validation rule would trigger this issue, applying the fix provided would be preferable to prevent the likelihood of triggering this issue through future additions or customizations.

[m2-assistant]

Hi @engcom-Dash. Thank you for working on this issue.
In order to make sure that issue has enough information and ready for development, please read and check the following instruction: 👇

• 1. Verify that issue has all the required information. (Preconditions, Steps to reproduce, Expected result, Actual result).
• 2. Verify that issue has a meaningful description and provides enough information to reproduce the issue.
• 3. Add Area: XXXXX label to the ticket, indicating the functional areas it may be related to.
• 4. Verify that the issue is reproducible on 2.4-develop branch
     Details

     - Add the comment @magento give me 2.4-develop instance to deploy test instance on Magento infrastructure.
     - If the issue is reproducible on 2.4-develop branch, please, add the label Reproduced on 2.4.x.
     - If the issue is not reproducible, add your comment that issue is not reproducible and close the issue and stop verification process here!

---

• Join Magento Community Engineering Slack and ask your questions in #github channel.

[engcom-Dash]

Hi @nikoelgatito ,

Verified the issue in 2.4.4 instance and the issue is not reproducible.

Preconditions:
Magento Version - 2.4.4
PHP 8.1

Steps:
1.Install Magento Instance
2.Install Page Builder in the Magento
3.Go to Admin Panel
4.Click on Sales >> Order
5.Edit the order.

Screenshots:

Let us know if we are missing Anything

Thanks.

[engcom-Dash]

Hi @nikoelgatito ,

We have noticed that this issue has not been updated for a period of 14 Days. Hence we assume that this issue is fixed now, so we are closing it. Please raise a fresh ticket or reopen this ticket if you need more assistance on this.

Regards