Cron captcha_delete_expired_images not working after Magento 2.4.8 update.

[gimanik]

Preconditions and environment

• Magento 2.4.8-p1 +

Steps to reproduce

Captcha files are not deleted anymore after update to Magento 2.4.8-p1 causing folder /media/captcha/base to grow over time.
(It IS still reproducible on 2.4-develop)
This commit runed it:
ab0fb9d
Issue is here:
Magento\Captcha\Cron\DeleteExpiredImages::_deleteExpiredImagesForWebsite

if ($this->_mediaDirectory->isFile($filePath)
    && $this->_fileInfo->getPathInfo($filePath, PATHINFO_EXTENSION) == 'png'
    && $this->_mediaDirectory->stat($filePath)['mtime'] < $expire
) {
    $this->_mediaDirectory->delete($filePath);
}

this is never gonna be true, because of condition:
$this->_fileInfo->getPathInfo($filePath, PATHINFO_EXTENSION) == 'png'
method getPathInfo always returns array, so comparsion to string "png" will always result in false.
@see Magento\Framework\Filesystem\Io\File::getPathInfo

public function getPathInfo($path)
{
    return pathinfo($path);
}

To fix it we should add another optional param to getPathInfo or change condition:

$this->_fileInfo->getPathInfo($filePath, PATHINFO_EXTENSION) == 'png'

to:

$this->_fileInfo->getPathInfo($filePath)['extension'] == 'png'

or bring back as it used to be before commit mentioned above (ab0fb9d):

pathinfo($filePath, PATHINFO_EXTENSION) == 'png'

Expected result

Captcha files are deleted by CRON captcha_delete_expired_images

Actual result

Captcha files are not deleted by captcha_delete_expired_images CRON

Additional information

No response

Release note

No response

Triage and priority

• Severity: S0 - Affects critical data or functionality and leaves users without workaround.
• Severity: S1 - Affects critical data or functionality and forces users to employ a workaround.
• Severity: S2 - Affects non-critical data or functionality and forces users to employ a workaround.
• Severity: S3 - Affects non-critical data or functionality and does not force users to employ a workaround.
• Severity: S4 - Affects aesthetics, professional look and feel, “quality” or “usability”.

[m2-assistant]

Hi @gimanik. Thank you for your report.
To speed up processing of this issue, make sure that the issue is reproducible on the vanilla Magento instance following Steps to reproduce.

• For more details, review the Magento Contributor Assistant documentation.
• Add a comment to assign the issue: @magento I am working on this
• To learn more about issue processing workflow, refer to the Code Contributions.

---

Join Magento Community Engineering Slack and ask your questions in #github channel.
⚠️ According to the Magento Contribution requirements, all issues must go through the Community Contributions Triage process. Community Contributions Triage is a public meeting.
🕙 You can find the schedule on the Magento Community Calendar page.
📞 The triage of issues happens in the queue order. If you want to speed up the delivery of your contribution, join the Community Contributions Triage session to discuss the appropriate ticket.

[m2-assistant]

Hi @engcom-Bravo. Thank you for working on this issue.
In order to make sure that issue has enough information and ready for development, please read and check the following instruction: 👇

• 1. Verify that issue has all the required information. (Preconditions, Steps to reproduce, Expected result, Actual result).
• 2. Verify that issue has a meaningful description and provides enough information to reproduce the issue.
• 3. Add Area: XXXXX label to the ticket, indicating the functional areas it may be related to.
• 4. Verify that the issue is reproducible on 2.4-develop branch
  Details

  - If the issue is reproducible on 2.4-develop branch, please, add the label Reproduced on 2.4.x.
  - If the issue is not reproducible, add your comment that issue is not reproducible and close the issue and stop verification process here!
• 5. Add label Issue: Confirmed once verification is complete.
• 6. Make sure that automatic system confirms that report has been added to the backlog.

[engcom-Bravo]

Hi @gimanik,

Thanks for your reporting and collaboration.

Could you please elaborate the steps to reproduce and also which version to you were upgrading to 2.4.8-p1.

Thanks.

[gimanik]

Error persist in every Magento 2 instance which is 2.4.8 or above.
Steps to reproduce:
Make Magento generate captcha png file (for example on frontend or admin by providing wrong password)
Check if file has been generated here: /media/captcha
Wait 20 min.
Cron captcha_delete_expired_images (<schedule>*/10 * * * *</schedule>, declared here: magento/module-captcha/etc/crontab.xml) should delete this png file.

I have already provided solution and explained bug above. It's really one-line fix.
Changing condition:

$this->_fileInfo->getPathInfo($filePath, PATHINFO_EXTENSION) == 'png'

to correct:

$this->_fileInfo->getPathInfo($filePath)['extension'] == 'png'

fixes the problem. Problem is that original line compares array like this:

array(4) {
  ["dirname"]=>
  string(13) "captcha/admin"
  ["basename"]=>
  string(36) "087e85538649320e02b1e73e31bba59d.png"
  ["extension"]=>
  string(3) "png"
  ["filename"]=>
  string(32) "087e85538649320e02b1e73e31bba59d"
}

to string "png"

[engcom-Bravo]

Hi @gimanik,

Thanks for your Update.

We have tried to reproduce the issue in Latest 2.4-develop instance and we are able to reproduce the issue. Captcha files are not deleted by captcha_delete_expired_images CRON.Hence Confirming the issue.

Thanks.