Magento\SalesRule\Model\Plugin\QuoteConfigProductAttributes::afterGetProductAttributes getting triggered on all Cart Queries

[senthilengg]

Preconditions and environment

• All Magento versions
• salesrule_product_attributes table select getting triggered and salesrule attribute data retrieved from EAV eventhough collectTotals not fired

Steps to reproduce

1. Add products to cart (collectTotals should have completed here)
2. Enable DB Query Log
3. Hit the cart page URL
4. To confirm the query fired run , cat var/log/db.log | grep "salesrule_product_attribute" from magento root

Expected result

salesrule_product_attribute query should be fired only when collectTotal happening

Actual result

salesrule_product_attribute query fired always

Additional information

For large catalog and companies who run lot of promotions will get benefit out of it.

Release note

No response

Triage and priority

• Severity: S0 - Affects critical data or functionality and leaves users without workaround.
• Severity: S1 - Affects critical data or functionality and forces users to employ a workaround.
• Severity: S2 - Affects non-critical data or functionality and forces users to employ a workaround.
• Severity: S3 - Affects non-critical data or functionality and does not force users to employ a workaround.
• Severity: S4 - Affects aesthetics, professional look and feel, “quality” or “usability”.

[m2-assistant]

Hi @senthilengg. Thank you for your report.
To speed up processing of this issue, make sure that the issue is reproducible on the vanilla Magento instance following Steps to reproduce.

• For more details, review the Magento Contributor Assistant documentation.
• Add a comment to assign the issue: @magento I am working on this
• To learn more about issue processing workflow, refer to the Code Contributions.

---

Join Magento Community Engineering Slack and ask your questions in #github channel.
⚠️ According to the Magento Contribution requirements, all issues must go through the Community Contributions Triage process. Community Contributions Triage is a public meeting.
🕙 You can find the schedule on the Magento Community Calendar page.
📞 The triage of issues happens in the queue order. If you want to speed up the delivery of your contribution, join the Community Contributions Triage session to discuss the appropriate ticket.

[engcom-Hotel]

Hello @senthilengg,

Thank you for the report and collaboration!

We have gone through with the issue and the scenario mentioned is reproducible for us. But seems that this is an expected behaviour due to the below reason:

It seems that the scenario is calling from the below pulgin:

magento2/app/code/Magento/SalesRule/Model/Plugin/QuoteConfigProductAttributes.php

Lines 41 to 49 in e044f74

	public function afterGetProductAttributes(Config $subject, array $attributeKeys): array
	{
	if ($this->activeAttributeCodes === null) {
	$this->activeAttributeCodes = array_column($this->ruleResource->getActiveAttributes(), 'attribute_code');
	}
	return array_merge($attributeKeys, $this->activeAttributeCodes);
	}
	}

This plugin intercepts every call to getProductAttributes(), which happens whenever quote items are loaded—not just during totals collection. The salesrule_product_attribute table stores which product attributes are used in active sales rule conditions/actions (e.g., "If product color = red, apply 10% discount"). These attributes must be loaded with the products before collectTotals() runs, because:

• Sales rules validation happens during totals collection
• The rule conditions need access to these product attributes
• Product collections for quote items are built before totals collection

Let us know if we missed anything while analysing the issue.

Thank you

[senthilengg]

@engcom-Hotel If there is no need of collectTotals to run which is a heavy process why would this plugin. Need to run and retrieve data.

Also on a million product catalog this table can contain few 100k rows which will add load time and leads to performance bottleneck. So it’s better to address this.

[engcom-Hotel]

Hello @senthilengg, you make an excellent point. After deeper analysis, I agree this is a performance issue.

The Problem:
The plugin fires on every quote item collection load (line 262 in Quote\Model\ResourceModel\Quote\Item\Collection.php), not just during totals collection. This means:

1. Viewing cart page → Plugin fires → Queries salesrule_product_attribute table
2. For catalogs with 100k+ rows in this table, this adds unnecessary load time
3. These attributes are loaded even when they won't be used (no totals recalculation)

Performance Impact:

• Unnecessary DB query on every cart view
• Additional EAV attribute loading overhead
• Scales poorly with number of rules × websites × customer groups × attributes

Potential Solutions:

1. Lazy Load: Only load salesrule attributes when collectTotals() is actually triggered
2. Conditional Check: Add flag to determine if rules need evaluation before loading attributes
3. Caching: Cache the active attributes per store/customer group to avoid repeated DB queries
4. Move Loading Point: Load attributes closer to rule validation in totals collection

Hence confirming the issue.

Thank you for bringing this issue to our attention. If you have a potential solution, we encourage you to submit a pull request. Your contributions significantly enhance Magento Open Source for everyone. Should you need any assistance, please don't hesitate to ask!