Skip to content

NewRelic Module - Remove unneeded dependencies #40243

@kristof-ringleff

Description

@kristof-ringleff

Preconditions and environment

The package magento/module-new-relic-reporting has a dependency on magento/magento-composer-installer which I do not believe to be used or necessary.

www-data@magento2-php-fpm$ composer why magento/magento-composer-installer
magento/magento-composer-installer  0.2.0    replaces  magento-hackathon/magento-composer-installer (*)
magento/module-new-relic-reporting  100.4.2  requires  magento/magento-composer-installer (*)

Steps to reproduce

  1. mkdir new-folder
  2. cd new-folder
  3. create composer.json with
{
    "name": "test/project",
    "type": "project",
    "require": {
        "magento/module-graph-ql": "100.4.4"
    }
}
  1. composer install

Expected result

No error

Actual result

Image

Additional information

I believe magento/module-graph-ql should not be tightly coupled to magento/module-new-relic-reporting and this functionality should instead be in a separate package.

Further magento/magento-composer-installer should be removed as dependency from magento/module-new-relic-reporting as I believe it is not used (or should not be used directly).

Release note

Tidy up dependencies for package magento/module-new-relic-reporting

Triage and priority

  • Severity: S0 - Affects critical data or functionality and leaves users without workaround.
  • Severity: S1 - Affects critical data or functionality and forces users to employ a workaround.
  • Severity: S2 - Affects non-critical data or functionality and forces users to employ a workaround.
  • Severity: S3 - Affects non-critical data or functionality and does not force users to employ a workaround.
  • Severity: S4 - Affects aesthetics, professional look and feel, “quality” or “usability”.

Metadata

Metadata

Assignees

No one assigned

    Labels

    Area: FrameworkComponent: ComposerIssue: ConfirmedGate 3 Passed. Manual verification of the issue completed. Issue is confirmedPriority: P3May be fixed according to the position in the backlog.Reproduced on 2.4.xThe issue has been reproduced on latest 2.4-develop branchTriage: Dev.ExperienceIssue related to Developer Experience and needs help with Triage to Confirm or Reject it

    Type

    No type

    Projects

    Status

    Ready for Development

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions