Skip to content

Conversation

jzembala
Copy link

Description (*)

Issue was already fixed in M2.2.8 but only for Configurable products. Same situation relates to Bundle product prices and it's indexer (SQL). All conditions there are correct, but are not grouped which results with wrong special_price data populating in indexer database tables.

Fixed Issues (if relevant)

  1. M2.2.6 : "Order by price" not working in product listing #18264: M2.2.6 : "Order by price" not working in product listing

Manual testing scenarios (*)

  1. Set same regular price for 2-3 bundle products
  2. Set same special_price on above products
  3. Set different dates in fields special_price_from and special_price_to, but having one product with special date valid for the day of testing.
  4. Assign above products to the same category
  5. Open that category page and watch results

Results:

Products are sorted as if they have same (special) price, but displayed price is correct according to dates set in special_price_from and special_price_to fields.
In catalog_product_index_price table all three products have set special_price.

Questions or comments

As I checked the issue is presenting in M2.3-develop as well.

Contribution checklist (*)

  • Pull request has a meaningful description of its purpose
  • All commits are accompanied by meaningful commit messages
  • All new or changed code is covered with unit/integration tests (if applicable)
  • All automated tests passed successfully (all builds are green)

@m2-assistant
Copy link

m2-assistant bot commented May 29, 2019

Hi @bizzi. Thank you for your contribution
Here is some useful tips how you can test your changes using Magento test environment.
Add the comment under your pull request to deploy test or vanilla Magento instance:

  • @magento give me test instance - deploy test instance based on PR changes
  • @magento give me 2.3-develop instance - deploy vanilla Magento instance

For more details, please, review the Magento Contributor Assistant documentation

@magento-cicd2
Copy link
Contributor

magento-cicd2 commented May 29, 2019

CLA assistant check
Thank you for your submission, we really appreciate it. Like many open source projects, we ask that you sign our Contributor License Agreement before we can accept your contribution.


Jakub Zembala seems not to be a GitHub user. You need a GitHub account to be able to sign the CLA. If you have already a GitHub account, please add the email address used for this commit to your account.

@Stepa4man Stepa4man self-requested a review May 29, 2019 15:41
@Stepa4man Stepa4man self-assigned this May 29, 2019
@ghost ghost added the Progress: on hold label May 29, 2019
Copy link
Contributor

@Stepa4man Stepa4man left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi, @bizzi. Please first provide this fix for 2.3-develop and sign Contributor License Agreement.
Thank you for your contribution.

@sidolov
Copy link
Contributor

sidolov commented Jul 15, 2019

@bizzi , I am closing this PR now due to inactivity.
Please reopen and update if you wish to continue.
Thank you for the collaboration!

@sidolov sidolov closed this Jul 15, 2019
@m2-assistant
Copy link

m2-assistant bot commented Jul 15, 2019

Hi @bizzi, thank you for your contribution!
Please, complete Contribution Survey, it will take less than a minute.
Your feedback will help us to improve contribution process.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants