Fix: paypal is not giving lastname in express checkout

[bradleybrecher]

Description (*)

Fixed Express checkout to show lastname in the the db for billing and shipping in guest mode. Two files were changed in the Magento\Paypal\Model, Checkout.php and Api\Nvp.php. For Checkout.php, had to comment out the lines that were setting the sipping details to NULL. In Api\Nvp.php , had to change the SHIPTONAME to split up the first and last name so each field can be saved respectively instead of the whole name in firstname.

Fixed Issues (if relevant)

1. paypal is not giving lastname in express checkout #23061: paypal is not giving lastname in express checkout

Manual testing scenarios (*)

1. Place a order on magento using express checkout in guest mode
2. After successful order, check sales_order and sales_order_adress table in db to confirm that order information is correct.

Contribution checklist (*)

• Pull request has a meaningful description of its purpose
• All commits are accompanied by meaningful commit messages
• All new or changed code is covered with unit/integration tests (if applicable)
• All automated tests passed successfully (all builds are green)

[m2-assistant]

Hi @bradleybrecher. Thank you for your contribution
Here is some useful tips how you can test your changes using Magento test environment.
Add the comment under your pull request to deploy test or vanilla Magento instance:

• @magento give me test instance - deploy test instance based on PR changes
• @magento give me 2.3-develop instance - deploy vanilla Magento instance

For more details, please, review the Magento Contributor Assistant documentation

[magento-cicd2]

All committers have signed the CLA.

[navarr]

Can SHIPTONAME contain more than two names? If so splitting and grabbing the second will result in inaccurate data

[bradleybrecher]

@navarr PayPal send the data for the SHIPTONAME as one string(separated by spaces). PayPal requires a first and last name on express checkout so there must be at least 2 names in the string. So what I propose (in my most recent commit) is in the case where there are more than one first and/or last name, make an assumption that it is a first name. In the small chance where there are 2 last names, the admin can edit orders manually rather than always editing the database to insert the name(the initial issue). This issue is discussed further on Adam Wilson's blog.

[pmclain]

A few syntax requests while the CI builds are still pending.

[pmclain]

@bradleybrecher Please review failing checks.

[sidolov]

Please, fix the code style issues, you need just to revert a lot of code styles changes made in the previous commits.

[sidolov]

@bradleybrecher I am closing this PR now due to inactivity.
Please reopen and update if you wish to continue.
Thank you for the collaboration!

[m2-assistant]

Hi @bradleybrecher, thank you for your contribution!
Please, complete Contribution Survey, it will take less than a minute.
Your feedback will help us to improve contribution process.

[hubertus2017]

Hmm, still the same problem in M2.4.4 !?!
Edit: Seems to be in bundled Braintree module, not in the express module mentioned here