Make email subject translatable #2388
Merged
+1
−1
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
When the email templates are being processed the template subject is not translatable because the translation happens within the filters via 'trans'. We must add the translated subject before the processor since there the variables used in the subject will be replaced and thus no longer be generic for translation. Signed-off-by: BlackEagle <ike.devolder@gmail.com>
Contributor
|
Thank you for your contribution! |
okorshenko
pushed a commit
that referenced
this pull request
Jan 4, 2016
…o2.git email-subject-translatable
magento-team
pushed a commit
that referenced
this pull request
Feb 5, 2016
…o2.git email-subject-translatable
Closed
4 tasks
magento-devops-reposync-svc
pushed a commit
that referenced
this pull request
Aug 29, 2025
Sync 2.4-develop into AC-14558-stomp-v2
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When the email templates are being processed the template subject is not
translatable because the translation happens within the filters via
'trans'. We must add the translated subject before the processor since
there the variables used in the subject will be replaced and thus no
longer be generic for translation.
Signed-off-by: BlackEagle ike.devolder@gmail.com