-
Notifications
You must be signed in to change notification settings - Fork 9.4k
Add to Cart mutations in GraphQl should consider Catalog Permissions #30019
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
magento-engcom-team
merged 1 commit into
magento:2.4-develop
from
pmarjan:add-to-cart-category-permissions-29930
Oct 10, 2020
Merged
Changes from all commits
Commits
File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
45 changes: 45 additions & 0 deletions
45
...Magento/QuoteGraphQl/Model/CartItem/DataProvider/Processor/ItemDataCompositeProcessor.php
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,45 @@ | ||
| <?php | ||
| /** | ||
| * Copyright © Magento, Inc. All rights reserved. | ||
| * See COPYING.txt for license details. | ||
| */ | ||
| declare(strict_types=1); | ||
|
|
||
| namespace Magento\QuoteGraphQl\Model\CartItem\DataProvider\Processor; | ||
|
|
||
| use Magento\GraphQl\Model\Query\ContextInterface; | ||
|
|
||
| /** | ||
| * {@inheritdoc} | ||
| */ | ||
| class ItemDataCompositeProcessor implements ItemDataProcessorInterface | ||
| { | ||
| /** | ||
| * @var ItemDataProcessorInterface[] | ||
| */ | ||
| private $itemDataProcessors; | ||
|
|
||
| /** | ||
| * @param ItemDataProcessorInterface[] $itemDataProcessors | ||
| */ | ||
| public function __construct(array $itemDataProcessors = []) | ||
| { | ||
| $this->itemDataProcessors = $itemDataProcessors; | ||
| } | ||
|
|
||
| /** | ||
| * Process cart item data | ||
| * | ||
| * @param array $cartItemData | ||
| * @param ContextInterface $context | ||
| * @return array | ||
| */ | ||
| public function process(array $cartItemData, ContextInterface $context): array | ||
| { | ||
| foreach ($this->itemDataProcessors as $itemDataProcessor) { | ||
| $cartItemData = $itemDataProcessor->process($cartItemData, $context); | ||
| } | ||
|
|
||
| return $cartItemData; | ||
| } | ||
| } |
25 changes: 25 additions & 0 deletions
25
...Magento/QuoteGraphQl/Model/CartItem/DataProvider/Processor/ItemDataProcessorInterface.php
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,25 @@ | ||
| <?php | ||
| /** | ||
| * Copyright © Magento, Inc. All rights reserved. | ||
| * See COPYING.txt for license details. | ||
| */ | ||
| declare(strict_types=1); | ||
|
|
||
| namespace Magento\QuoteGraphQl\Model\CartItem\DataProvider\Processor; | ||
|
|
||
| use Magento\GraphQl\Model\Query\ContextInterface; | ||
|
|
||
| /** | ||
| * Process Cart Item Data | ||
| */ | ||
| interface ItemDataProcessorInterface | ||
| { | ||
| /** | ||
| * Process cart item data | ||
| * | ||
| * @param array $cartItemData | ||
| * @param ContextInterface $context | ||
| * @return array | ||
| */ | ||
| public function process(array $cartItemData, ContextInterface $context): array; | ||
| } |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I wonder what's going to happen to the items that already exist in cart settings are changed after?
should we add some checks to placeOrder? is core doing that?