Skip to content

Conversation

@senthilengg
Copy link

@senthilengg senthilengg commented Nov 14, 2025

Description (*)

  1. Added condition to check whether collectTotals must be processed if not retrieve from the DB values
  2. Update the discount amount retrieval from extension attributes to child discount amount, since the extension attribute values are only set during collectTotals

Fixed Issues

  1. Fixes Cart Query >> CartItemPrices GraphQl Performance Optimisation #40235

Manual testing scenarios (*)

  1. GraphQl cart API should tested with CartItemPrices
  2. Make sure Simple+Bundle , configurable+bundle and all product types in cart

Contribution checklist (*)

  • Pull request has a meaningful description of its purpose
  • All commits are accompanied by meaningful commit messages
  • All new or changed code is covered with unit/integration tests (if applicable)
  • README.md files for modified modules are updated and included in the pull request if any README.md predefined sections require an update
  • All automated tests passed successfully (all builds are green)

Senthilkumar Muppidathi added 2 commits November 14, 2025 13:12
@m2-assistant
Copy link

m2-assistant bot commented Nov 14, 2025

Hi @senthilengg. Thank you for your contribution!
Here are some useful tips on how you can test your changes using Magento test environment.
❗ Automated tests can be triggered manually with an appropriate comment:

  • @magento run all tests - run or re-run all required tests against the PR changes
  • @magento run <test-build(s)> - run or re-run specific test build(s)
    For example: @magento run Unit Tests

<test-build(s)> is a comma-separated list of build names.

Allowed build names are:
  1. Database Compare
  2. Functional Tests CE
  3. Functional Tests EE
  4. Functional Tests B2B
  5. Integration Tests
  6. Magento Health Index
  7. Sample Data Tests CE
  8. Sample Data Tests EE
  9. Sample Data Tests B2B
  10. Static Tests
  11. Unit Tests
  12. WebAPI Tests
  13. Semantic Version Checker

You can find more information about the builds here
ℹ️ Run only required test builds during development. Run all test builds before sending your pull request for review.


For more details, review the Code Contributions documentation.
Join Magento Community Engineering Slack and ask your questions in #github channel.

@senthilengg
Copy link
Author

@magento run all tests

@florinel-chis
Copy link

why would this be merged or approved? it's a breaking change. especially for any company that has tests and contract testing.

@senthilengg senthilengg marked this pull request as draft November 14, 2025 11:42
@senthilengg
Copy link
Author

senthilengg commented Nov 14, 2025

why would this be merged or approved? it's a breaking change. especially for any company that has tests and contract testing.

@florinel-chis This PR will not be merged until I fix the automated tests. OOB Magento itself doesn’t have test script for CartItemPrices so I have to write from scratch.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Cart Query >> CartItemPrices GraphQl Performance Optimisation

2 participants