Skip to content

Conversation

@mimou78
Copy link
Contributor

@mimou78 mimou78 commented Nov 17, 2025

Summary

This pull request fixes an issue where the product count displayed in the Admin Category Grid
incorrectly shows 0 products for categories that do not have any descendants.
The current logic only counts products assigned to descendant categories and does not
include products directly assigned to the category itself.

Problem

When building the temporary table of category → descendant relationships, the SQL
logic only inserts rows for descendants, not for the category itself.
As a result:

  • Leaf categories always show 0 products
  • Parent categories show incomplete counts
  • The Admin UI becomes misleading for merchants

Related Issue
Fixes #40263

What This Fix Does

This change ensures that each category always includes a self-reference entry in
the temporary category/descendant table.
As a result:

  • Products directly assigned to the category are counted correctly
  • Categories without children no longer show a zero count
  • Product assignment visibility in Admin becomes accurate

Technical Changes

  • Added a self-reference row (category_id = X, descendant_id = X) for every
    processed category ID.
  • Ensured that the final SQL aggregation counts products from both descendants
    and the category itself.
  • Updated unit tests to validate multiple insert calls for self-references.

Testing Instructions

  1. Create a category with no children.
  2. Assign one or more products to it.
  3. Clear cache and refresh the Category Grid.
  4. Product count should now display the correct value instead of zero.
  5. Repeat with nested categories to confirm descendant counts still work.

Backward Compatibility

  • No schema changes.
  • No API changes.
  • Fully backward compatible.

Risks

Low. This affects only the temporary table generation used for counting, not
the category model or product relations.

@m2-assistant
Copy link

m2-assistant bot commented Nov 17, 2025

Hi @mimou78. Thank you for your contribution!
Here are some useful tips on how you can test your changes using Magento test environment.
❗ Automated tests can be triggered manually with an appropriate comment:

  • @magento run all tests - run or re-run all required tests against the PR changes
  • @magento run <test-build(s)> - run or re-run specific test build(s)
    For example: @magento run Unit Tests

<test-build(s)> is a comma-separated list of build names.

Allowed build names are:
  1. Database Compare
  2. Functional Tests CE
  3. Functional Tests EE
  4. Functional Tests B2B
  5. Integration Tests
  6. Magento Health Index
  7. Sample Data Tests CE
  8. Sample Data Tests EE
  9. Sample Data Tests B2B
  10. Static Tests
  11. Unit Tests
  12. WebAPI Tests
  13. Semantic Version Checker

You can find more information about the builds here
ℹ️ Run only required test builds during development. Run all test builds before sending your pull request for review.


For more details, review the Code Contributions documentation.
Join Magento Community Engineering Slack and ask your questions in #github channel.

@ct-prd-pr-scan
Copy link

The security team has been informed about this pull request due to the presence of risky security keywords. For security vulnerability reports, please visit Adobe's vulnerability disclosure program on HackerOne or email psirt@adobe.com.

1 similar comment
@ct-prd-pr-scan
Copy link

The security team has been informed about this pull request due to the presence of risky security keywords. For security vulnerability reports, please visit Adobe's vulnerability disclosure program on HackerOne or email psirt@adobe.com.

@mimou78
Copy link
Contributor Author

mimou78 commented Nov 17, 2025

@magento run all tests

@engcom-Bravo engcom-Bravo added the Priority: P2 A defect with this priority could have functionality issues which are not to expectations. label Nov 18, 2025
@github-project-automation github-project-automation bot moved this to Pending Review in Pull Requests Dashboard Nov 18, 2025
@swnsma swnsma self-assigned this Nov 19, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Priority: P2 A defect with this priority could have functionality issues which are not to expectations. Progress: pending review

Projects

Status: Pending Review

Development

Successfully merging this pull request may close these issues.

Categories Product Amount shown as 0 in admin

3 participants