Replace boolean cast to be able to disable frame, aspect ratio, trans… #7262
Conversation
…parency or constrain only in view.xml If you set frame to false in view.xml the code would cast it to true because (bool)'false' is equal to true. By using the filter_var function the cast to boolean is done correctly.
|
This will fix issue #4622 |
| public function setKeepAspectRatio($keep) | ||
| { | ||
| $this->_keepAspectRatio = (bool)$keep; | ||
| $this->_keepAspectRatio = filter_var($keep, FILTER_VALIDATE_BOOLEAN); |
There was a problem hiding this comment.
Would something like
$this->_keepAspectRatio = $keep && $keep !== 'false';
do the trick and make an intention clearer for somebody who read the code? ;)
|
@orlangur It is indeed a better way. I have changed it. |
|
@orlangur Is this PR going to be merged? |
|
@Ctucker9233 I believe yes, as it's still perfect :) Cannot do it by myself, here you can track the progress of PR processing: https://github.com/magento/magento2/projects/3 It will take some time to process all old PRs, if you really need this fix in next release please ping somebody from Magento team. Cannot evaluate severity of this issue by myself. |
|
@magento-team Would like to request that this PR be merged. |
|
@Ctucker9233 @joost-florijn-kega PR have been merged into the |
| public function setKeepAspectRatio($keep) | ||
| { | ||
| $this->_keepAspectRatio = (bool)$keep; | ||
| $this->_keepAspectRatio = $keep && $keep !== 'false'; |
There was a problem hiding this comment.
Actually, you could probably just do a json_decode($keep) here..
There was a problem hiding this comment.
Even if json_decode works it would be much slower and much less clear.
7 participants
…parency or constrain only in view.xml
If you set frame to false in view.xml the code would cast it to true because
(bool)'false'is equal totrue. By using thefilter_varfunction the cast to boolean is done correctly.