feat: add accessibility tooltips and labels to framing controls#295
Conversation
|
@aksharsawhney74-rgb is attempting to deploy a commit to the magic-peach1's projects Team on Vercel. A member of the Team first needs to authorize it. |
aksharsawhney74-rgb
force-pushed
the
fix/your-new-feature
branch
from
2af8413 to
29a2456
Compare
magic-peach
added
feature
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
|
@aksharsawhney74-rgb please fix the errors i am unable to merge because the CI/build is failing |
|
Hi @magic-peach |
please resolve the error
|
…x/your-new-feature git push origin fix/your-new-feature# especially if it merges an updated upstream into a topic branch.
✅ PR Format Check Passed — @aksharsawhney74-rgbBasic format checks passed. A maintainer will review your code changes. This does not mean the PR is approved — it just means the format is correct. |
|
@magic-peach solved the issue |
magic-peach
added
gssoc:approved
2 participants
Changes Made
Visible Labels: Added explicit "Fit" and "Fill" text labels to the toggle buttons.
Descriptive Subtitles: Included subtitles ("Letterbox / pillarbox" and "Crop to frame") to provide immediate context for each framing mode.
Accessibility Tooltips: Implemented the title attribute on both buttons to provide descriptive tooltips for desktop users:
Fit: "Fit the image within the frame"
Fill: "Fill the frame by cropping"
Screen Reader Support: Maintained sr-only spans to ensure the component remains fully accessible to users with visual impairments.
Impact
These changes ensure that the framing controls meet the project's accessibility standards and provide a clearer user experience for all users.
Closes #177