fix: resolve blob memory leak and syntax errors

[aksharsawhney74-rgb]

error in syntax which was creating problem in building now fixed
Closes #142

[vercel]

@aksharsawhney74-rgb is attempting to deploy a commit to the magic-peach1's projects Team on Vercel.

A member of the Team first needs to authorize it.

[github-actions]

👋 Thanks for your PR, @aksharsawhney74-rgb!

Welcome to Reframe — a browser-based video editor built for everyone 🎬

What happens next

1. 🤖 Automated checks — build & TypeScript typecheck will run automatically
2. ✅ Vercel preview — a preview deployment will be created (requires maintainer authorization for fork PRs)
3. 👀 Code review — a maintainer will review your changes
4. 🚀 Merge — once approved, your PR will be merged!

Quick checklist

• PR title follows Conventional Commits (e.g. feat: add dark mode)
• Linked the issue this PR closes (e.g. Closes #123)
• Tested the changes locally (bun run dev)
• Build passes (bun run build)

Useful links

• 📖 CONTRIBUTING.md
• 🐛 Open Issues
• ⭐ Star the repo to support the project!

Happy coding! 🎉

[github-actions]

✅ PR Format Check Passed — @aksharsawhney74-rgb

Basic format checks passed. A maintainer will review your code changes.

This does not mean the PR is approved — it just means the format is correct.

[magic-peach]

Hey @aksharsawhney74-rgb! Thanks for the PR 🙏

One issue: this project uses Bun as the package manager, so package-lock.json should not be committed — it's the npm lockfile, not Bun's.

Fix:

1. Delete package-lock.json from your commit
2. If you added new dependencies, run bun add <package-name> to update bun.lock instead
3. Commit only the bun.lock changes (and package.json if changed)

git rm package-lock.json
git add bun.lock package.json  # if changed
git commit --amend --no-edit
git push --force-with-lease

Tagged: gssoc'26 needs-fixes

[aksharsawhney74-rgb]

Hey @magic-peach! Thanks for your patience. I've got everything completely sorted out and updated to the latest main branch:

Removed package-lock.json and ensured everything uses Bun.

Fixed the stray JSX syntax error in page.tsx that was failing the build.

Resolved the upstream merge conflicts in DownloadResult.tsx while keeping your new styling updates and ensuring the memory leak fix (URL.revokeObjectURL) is perfectly attached to the download button.

The CI build is green and this should be fully ready to merge. Let me know if you need anything else
Closes #142

[magic-peach]

@aksharsawhney74-rgb please resolve conflicts

[magic-peach]

Hey @aksharsawhney74-rgb! The build is failing because your branch has a conflict with the current main:

Error — src/app/page.tsx:

Expression expected — Syntax Error

This is happening because your PR was built before a critical fix was pushed to main that resolved a duplicate JSX block in page.tsx. Your branch still has the old, broken version of page.tsx.

Fix — rebase onto main:

git fetch origin
git rebase origin/main

When you hit the conflict in src/app/page.tsx, keep the current main version (the clean one), which looks like:

import VideoEditor from "@/components/VideoEditor";
export default function Home() {
  return (
    <>
      <a href="https://github.com/magic-peach/reframe" ...>⭐ Star on GitHub</a>
      <VideoEditor />
    </>
  );
}

Do not add a <main> wrapper — the project doesn't use one in page.tsx.

Then git push --force-with-lease and CI will pass. 🚀

[magic-peach]

Hi @aksharsawhney74-rgb 👋 The CI build is currently failing on this PR. Could you check the build logs and fix the issue? Once the build passes, this will be ready to merge.

You can view the build failure by clicking on the failed check in the PR. Please fix the errors and push an update. 🙂

[aksharsawhney74-rgb]

@magic-peach
I am currently out of the town
I will resolve the issue once i reach home

[magic-peach]

Hey @aksharsawhney74-rgb, this PR has merge conflicts with main. Please merge/rebase main into your branch and resolve the conflicts before we can review it. Run: git fetch upstream && git merge upstream/main

[magic-peach]

Hey @aksharsawhney74-rgb! The blob memory leak fix is important. However, this PR modifies both page.tsx and DownloadResult.tsx.

Issues:

1. DownloadResult.tsx was recently updated by PR feat: add character count and validation to filename input (#204) #513 (added filename validation). Please rebase and resolve the conflict.
2. page.tsx changes — per CLAUDE.md, changes to page.tsx should only be made when strictly necessary for the specific fix, and contributor changes adding a <main> wrapper are discarded. Please check if your page.tsx changes are necessary for the memory leak fix.

Please rebase on latest main and keep the PR focused on just the memory leak fix.

[magic-peach]

Hey @aksharsawhney74-rgb! The build check is failing for this PR. Please review the build logs, fix the error, and push an update. Once the build passes and the code looks clean, this will be ready to merge. Let me know if you need help identifying the issue!

[magic-peach]

Hey @aksharsawhney74-rgb! Fixing blob memory leaks is important. This PR has:

1. Merge conflicts with main
2. Build is failing
3. Lint is failing

Please rebase and fix build + lint errors.

[magic-peach]

Hey @aksharsawhney74-rgb! This PR has CI check failures (build/lint/typecheck) and merge conflicts with main. Please:

1. Rebase onto main to resolve conflicts
2. Fix the build/lint/typecheck errors

git fetch origin
git rebase origin/main
# fix any errors, then:
git push --force-with-lease

Once all checks pass, we'll review and merge!

[magic-peach]

Hey @aksharsawhney74-rgb! This PR had merge conflicts with main — I've resolved them automatically and pushed. Conflicts were resolved by keeping main's versions of core files while preserving your changes. CI has been re-triggered. Once it passes, we'll review for merge!

[magic-peach]

Hey @aksharsawhney74-rgb! After resolving merge conflicts, the PR currently shows no diff against main — this means main has already incorporated similar changes, or our conflict resolution took main's version of the affected files.

If your blob memory leak fix is not reflected in the current diff, please rebase onto the latest main, verify your changes are still present, and push again. The build/lint/typecheck checks all pass now!