Skip to content

feat: add character count and validation to filename input (#204)#513

Merged
magic-peach merged 3 commits into
magic-peach:mainfrom
Rucha0901:feat/filename-validation-204
May 17, 2026
Merged

feat: add character count and validation to filename input (#204)#513
magic-peach merged 3 commits into
magic-peach:mainfrom
Rucha0901:feat/filename-validation-204

Conversation

@Rucha0901
Copy link
Copy Markdown
Contributor

Overview

Closes #204.

This PR implements a real-time character count and validation for the custom filename input in the DownloadResult component. This ensures users can't download files with invalid OS characters or excessively long filenames.

Changes Made

  • Added a filename text input replacing the previously hardcoded filename logic.
  • Validation: Added a regex check (/[<>:"/\\|?*]/) to detect invalid characters in real-time.
  • UI Enhancements:
    • Displays remaining characters (100 character max length enforced).
    • Turns input borders and the remaining character count red when limits or invalid characters are detected.
    • Shows an inline error message immediately when invalid characters are typed.
    • Prevents downloading (button visual state reflects disabled state and href clears) until the filename is corrected.

…ch#204)

Add custom filename input with real-time validation for invalid characters and a 100 character max limit. The download button is disabled if the filename is invalid or empty.

Signed-off-by: Rucha <imt_2025071@iiitm.ac.in>
@vercel
Copy link
Copy Markdown

vercel Bot commented May 16, 2026

@Rucha0901 is attempting to deploy a commit to the magic-peach1's projects Team on Vercel.

A member of the Team first needs to authorize it.

@github-actions
Copy link
Copy Markdown
Contributor

github-actions Bot commented May 16, 2026

✅ PR Format Check Passed — @Rucha0901

Basic format checks passed. A maintainer will review your code changes.

This does not mean the PR is approved — it just means the format is correct.

@github-actions
Copy link
Copy Markdown
Contributor

👋 Thanks for your PR, @Rucha0901!

Welcome to Reframe — a browser-based video editor built for everyone 🎬

What happens next

  1. 🤖 Automated checks — build & TypeScript typecheck will run automatically
  2. Vercel preview — a preview deployment will be created (requires maintainer authorization for fork PRs)
  3. 👀 Code review — a maintainer will review your changes
  4. 🚀 Merge — once approved, your PR will be merged!

Quick checklist

  • PR title follows Conventional Commits (e.g. feat: add dark mode)
  • Linked the issue this PR closes (e.g. Closes #123)
  • Tested the changes locally (bun run dev)
  • Build passes (bun run build)

Useful links

Happy coding! 🎉

@github-actions github-actions Bot added level:intermediate Intermediate level - 35 pts type:bug Bug fix type:design UI/UX design labels May 16, 2026
Fix unescaped entities in DownloadResult.tsx and exhaustive-deps warning in useVideoEditor.ts.

Signed-off-by: Rucha <imt_2025071@iiitm.ac.in>
@magic-peach magic-peach added gssoc'26 GirlScript Summer of Code 2026 quality:clean Well-implemented, clean code labels May 17, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

gssoc:approved Approved for GSSoC'26 gssoc'26 GirlScript Summer of Code 2026 level:intermediate Intermediate level - 35 pts quality:clean Well-implemented, clean code type:bug Bug fix type:design UI/UX design

Projects

None yet

Development

Successfully merging this pull request may close these issues.

[Good First Issue] Add character count / validation to filename input

2 participants