fix: remove leftover console log from useVideoEditor by Pravallika21-nama · Pull Request #830 · magic-peach/reframe

Pravallika21-nama · 2026-05-21T04:17:01Z

Description

This PR removes leftover debug console.log statements from the useVideoEditor hook to clean up the codebase and avoid unnecessary logs in production.

Related Issue

Closes #826

Type of Contribution

Bug fix
New feature
Documentation update
GSSoC contribution

Participant Info

GitHub username: Pravallika21-nama
Contribution level: Beginner

Screen Recording

Not applicable, as this change does not affect UI or user-facing features.

Checklist

I have read the contribution guidelines
My changes follow the project structure
I have tested my changes
bun run lint passes
bunx tsc --noEmit passes
No console.log statements left in
This PR is related to a valid issue

vercel · 2026-05-21T04:17:06Z

@Pravallika21-nama is attempting to deploy a commit to the magic-peach1's projects Team on Vercel.

A member of the Team first needs to authorize it.

chatgpt-codex-connector · 2026-05-21T04:17:07Z

You have reached your Codex usage limits for code reviews. You can see your limits in the Codex usage dashboard.

github-actions · 2026-05-21T04:17:10Z

👋 Thanks for your PR, @Pravallika21-nama!

Welcome to Reframe — a browser-based video editor built for everyone 🎬

🟠 GSSoC'26 PR detected — thanks for contributing under GirlScript Summer of Code 2026!

What happens next

🤖 Automated checks — build & TypeScript typecheck will run automatically
✅ Vercel preview — a preview deployment will be created (requires maintainer authorization for fork PRs)
👀 Code review — a maintainer will review your changes
🚀 Merge — once approved, your PR will be merged!

Quick checklist

PR title follows Conventional Commits (e.g. feat: add dark mode)
Linked the issue this PR closes (e.g. Closes #123)
Tested the changes locally (bun run dev)
Build passes (bun run build)

Useful links

📖 CONTRIBUTING.md
🐛 Open Issues
⭐ Star the repo to support the project!

Happy coding! 🎉

github-actions · 2026-05-21T04:17:10Z

✅ PR Format Check Passed — @Pravallika21-nama

Basic format checks passed. A maintainer will review your code changes.

This does not mean the PR is approved — it just means the format is correct.

Pravallika21-nama · 2026-05-21T04:25:22Z

Hi @maintainers, I’ve updated the PR title to follow the conventional format.
Please let me know if anything else is needed. Thanks!

magic-peach · 2026-05-21T16:25:18Z

Hey @Pravallika21-nama! CI hasn't run on this PR yet. Please rebase on main to trigger the build/lint/typecheck checks:

git fetch origin
git rebase origin/main
git push --force-with-lease

Also, please attach a screen recording showing your change working in the browser (see CONTRIBUTING.md for instructions). Both CI and a recording are required before a PR can be merged.

Pravallika21-nama · 2026-05-21T16:52:21Z

Hi @magic-peach, thanks for the guidance!

I’ll rebase the PR on main and resolve the CI issues shortly. I’ll also add the required screen recording demonstrating the change in the browser.

Could you please assign this PR to me?

I expect to complete these updates within the next 1–2 hours. Please let me know if anything else is needed. Thanks!

Pravallika21-nama · 2026-05-21T18:12:07Z

Hi @magic-peach, I’ve fixed the issues and removed the leftover console logs.

The app is now running without errors, and the console is clean.

I’ve attached a short screen recording below showing everything working as expected.

Please let me know if any further changes are needed. Thanks!

Recording.2026-05-21.232521-reframe.mp4

Pravallika21-nama · 2026-05-21T19:17:54Z

hy @magic-peach i had few changes to make ill get back tmrw

* feat: add audio waveform to trim control * fix: remove package-lock.json and unused prettier dev dependencies * fix: repair TrimControl typecheck * feat: add audio waveform to trim control * fix: remove package-lock.json and unused prettier dev dependencies fix: repair TrimControl typecheck * fix: resolve trim validation icon/messages * fix: resolve CI failures - fix TS error, remove unused imports, add package-lock.json to gitignore Co-authored-by: Akanksha Trehun <146705736+magic-peach@users.noreply.github.com>

magic-peach#724) * feat: integrate ffmpeg deshake filter for video stabilization Signed-off-by: Vagventure <ankitverma0366@gmail.com> * feat: add social media quick-action row to PresetSelector Co-authored-by: Akanksha Trehun <146705736+magic-peach@users.noreply.github.com> * feat: implement two-pass high-quality GIF export via FFmpeg Signed-off-by: Vagventure <ankitverma0366@gmail.com> --------- Signed-off-by: Vagventure <ankitverma0366@gmail.com>

* feat: add thumbnail strip for video frame navigation * fix: clean up all merge conflicts, fix memory leak in videoSrc * feat: add audio normalization, fix preview mute and speed * fix: correct useEffect dependency array syntax in VideoPreview * fix: export buildAudioFilter function * fix: add recipe to useEffect deps, add track element to video Co-authored-by: Akanksha Trehun <146705736+magic-peach@users.noreply.github.com>

Co-authored-by: Akanksha Trehun <146705736+magic-peach@users.noreply.github.com>

…ne (magic-peach#794) Co-authored-by: Akanksha Trehun <146705736+magic-peach@users.noreply.github.com>

* nvda-testing-01 * nvda-testing-02 Co-authored-by: Akanksha Trehun <146705736+magic-peach@users.noreply.github.com>

* fix(ui): hide number input spinners to prevent value visibility overlap (magic-peach#776) Browser-native increment/decrement arrows on <input type='number'> fields overlap with entered values in narrow containers, making text hard to read. Fix: suppress the spinner UI using cross-browser Tailwind arbitrary-value classes: - [appearance:textfield] — Firefox - [&::-webkit-outer-spin-button]:appearance-none — Chrome/Brave/Edge/Safari - [&::-webkit-inner-spin-button]:appearance-none — Chrome/Brave/Edge/Safari Affected inputs: - TrimControl.tsx — Start (sec) and End (sec) number fields - PresetSelector.tsx — Custom Width (px) and Height (px) fields Keyboard up/down arrow key stepping still works; only the visual spinner arrows are removed, which fully resolves the overlap/readability bug. Closes magic-peach#776 * feat(ui): add highlighted box around REFRAME title (magic-peach#775) The REFRAME title blended into the background without clear visual distinction. Wrap the h1 + subtitle in a styled container to make the brand mark prominent and immediately recognisable. Changes to src/components/VideoEditor.tsx: - Wrap <h1>REFRAME</h1> and its subtitle <p> in a div with: border border-[var(--border)] — respects light / dark mode border token border-l-4 border-l-film-600 — film-red left accent bar for brand identity bg-[var(--surface)] — lifted surface so it reads off the page bg rounded-xl — consistent corner radius with card system px-5 py-3 — breathing room around the text shadow-sm — subtle depth to separate from background - aria-label added so screen readers announce the landmark correctly The box reuses existing design tokens and film-600 brand colour, so it adapts automatically to light, dark and high-contrast themes. Closes magic-peach#775 Co-authored-by: Akanksha Trehun <146705736+magic-peach@users.noreply.github.com>

…ap (magic-peach#776) (magic-peach#778) Browser-native increment/decrement arrows on <input type='number'> fields overlap with entered values in narrow containers, making text hard to read. Fix: suppress the spinner UI using cross-browser Tailwind arbitrary-value classes: - [appearance:textfield] — Firefox - [&::-webkit-outer-spin-button]:appearance-none — Chrome/Brave/Edge/Safari - [&::-webkit-inner-spin-button]:appearance-none — Chrome/Brave/Edge/Safari Affected inputs: - TrimControl.tsx — Start (sec) and End (sec) number fields - PresetSelector.tsx — Custom Width (px) and Height (px) fields Keyboard up/down arrow key stepping still works; only the visual spinner arrows are removed, which fully resolves the overlap/readability bug. Closes magic-peach#776 Co-authored-by: Akanksha Trehun <146705736+magic-peach@users.noreply.github.com>

magic-peach#57) (magic-peach#772) - Add min-h-[44px] to the export button to guarantee the minimum 44px touch target height on all screen sizes (WCAG 2.5.5 recommendation) - w-full already present so button spans full container width on mobile (grid collapses to single column on screens < lg breakpoint) - Also update ffmpeg.test.ts to match new buildAudioFilter(speed, normalizeAudio) signature introduced in upstream main Closes magic-peach#57 Co-authored-by: Akanksha Trehun <146705736+magic-peach@users.noreply.github.com>

…ic-peach#751) * feat(shortcut): add M key to toggle audio mute (magic-peach#173) - Move M-key handler from AudioSpeedControl into useVideoEditor hook so the shortcut is guarded by ile (only fires when a video is loaded) - Protect against text input focus (INPUT, TEXTAREA, contentEditable) - Also guard against Ctrl/Meta/Alt modifiers to avoid conflicts - Use setRecipe functional update (no stale-closure risk; no extra deps) - Add visible M kbd badge on the mute toggle button for discoverability - Add collapsible KeyboardShortcutsPanel in the right sidebar documenting both shortcuts: M (mute) and Ctrl+Enter (export) Closes magic-peach#173 * fix(lint): remove redundant ul role and add missing useCallback deps - VideoEditor.tsx: remove role='list' from <ul> (jsx-a11y/no-redundant-roles) ul already has an implicit list role; the explicit attribute is redundant - useVideoEditor.ts: add loopMusic, musicFile, musicVolume, originalAudioVolume to handleExport dependency array (react-hooks/exhaustive-deps) * fix(typecheck): update ffmpeg.test.ts for new buildAudioFilter signature Upstream added normalizeAudio: boolean as a required second param to buildAudioFilter. Update all test call sites to pass false (no normalization), and add a new test case verifying the loudnorm filter is appended when normalizeAudio is true. Also fix stray '++' syntax corruption in presets.ts introduced during merge. Co-authored-by: Akanksha Trehun <146705736+magic-peach@users.noreply.github.com>

Co-authored-by: Akanksha Trehun <146705736+magic-peach@users.noreply.github.com>

Extends the existing exportEstimate.ts utility with a more accurate file size estimation model. Changes: - Fix preset resolution lookup — previously always used customWidth/Height even when a named preset (1080p, 4K, etc.) was selected - Replace 4-bucket CRF lookup with exponential curve fit to real H.264 reference points (CRF 18 ≈ 8 Mbps, 23 ≈ 3 Mbps, 30 ≈ 0.6 Mbps) - Fix speed scaling — was incorrectly dividing bitrate by speed; speed now only scales output duration - Add sqrt-damped resolution multiplier for more accurate high-res estimates - Add format overhead factor (webm ~15% smaller, mkv ~2% larger than mp4) - Add audio track estimate (AAC 128 kbps) - Add unit tests covering all estimation behaviours Closes magic-peach#657 Co-authored-by: Akanksha Trehun <146705736+magic-peach@users.noreply.github.com>

* fix: remove duplicate file format text in upload area * fix: add unique page titles for /privacy and /contact pages --------- Co-authored-by: Akanksha Trehun <146705736+magic-peach@users.noreply.github.com>

Raises the metadata load timeout to 5 s for large/slow-device compatibility and improves the error message. Closes magic-peach#729.

…rval> (magic-peach#650) Makes timer ref types environment-agnostic, removing the Node.js-specific NodeJS.Timeout type that caused CI errors in browser environments.

… leak (magic-peach#639) Adds a useEffect cleanup that calls terminateFFmpeg() when the editor unmounts, preventing the FFmpeg WebAssembly instance from staying in memory after navigation.

…each#871) Adds the Next.js Metadata TypeScript type to Contact and Privacy pages, and standardises title separators to use an em-dash (—) consistent with the rest of the site.

) Adds a subtle hover animation (translate-y-0.5, accent border, soft glow) to the footer feature badge chips using CSS variables and Tailwind transitions.

…#810) Adds a subtle hover scale + glow effect to the Star on GitHub button in the header, improving interactivity feedback.

Closes magic-peach#773.

…c-peach#698) Changes preset button aria-labels from the awkward '9 is to 16 output ratio' format to 'Reels 9:16' style labels that are more meaningful for screen reader users.

…agic-peach#838) Saves the complete recipe to localStorage on every change (debounced 500ms) and restores it on page load. Validates shape with isValidRecipe() including a version check so stale/incompatible saved data is gracefully ignored. resetSettings() and reset() both clear the stored recipe. Closes magic-peach#656.

Fixes inaccurate GIF size prediction. Closes magic-peach#795.

Adds client-side bounds checking (16-7680px) and autocomplete=off to custom width/height inputs. Closes magic-peach#844.

Adds a film-strip SVG logo to the header navbar alongside the Reframe wordmark. Closes magic-peach#809.

Enables stricter TypeScript array access checking (noUncheckedIndexedAccess) and fixes all resulting unsafe accesses. Strengthens type safety across the codebase.

Switches thumbnail canvas output from base64 data URLs to Blob object URLs, reducing memory footprint. Adds proper cleanup on unmount.

Adds a completion chime on export with a mute/unmute toggle button. Accessible (aria-labels on Volume2/VolumeX icons). All CI passing.

Wires up the framing overlay loop and repositions overlay indicators in VideoPreview.

git rebase --continue git rebase --continue

Pravallika21-nama added 4 commits May 21, 2026 00:59

fix: remove leftover debug console log from useVideoEditor

6d85a20

fix: remove leftover debug console log from useVideoEditor

28d2cb5

fix: remove debug console log and cleanup empty block

12982e3

fix: remove leftover debug console logs

c75e423

github-actions Bot added level:beginner Beginner level - 20 pts type:bug Bug fix type:design UI/UX design type:docs Documentation type:feature New feature type:refactor Code refactor gssoc'26 GirlScript Summer of Code 2026 labels May 21, 2026

Pravallika21-nama changed the title ~~Clean console log fix~~ fix: remove leftover console log from useVideoEditor May 21, 2026

ionfwsrijan and others added 9 commits May 22, 2026 13:29

Enhanced navigation hover animations (magic-peach#801)

09b9e3c

Co-authored-by: Akanksha Trehun <146705736+magic-peach@users.noreply.github.com>

feat/shareable-settings-url (magic-peach#799)

1f88ab5

Co-authored-by: Akanksha Trehun <146705736+magic-peach@users.noreply.github.com>

feat: add asynchronous audio waveform canvas rendering to trim timeli…

859f636

…ne (magic-peach#794) Co-authored-by: Akanksha Trehun <146705736+magic-peach@users.noreply.github.com>

nvda screen reader testing (magic-peach#785)

695771a

* nvda-testing-01 * nvda-testing-02 Co-authored-by: Akanksha Trehun <146705736+magic-peach@users.noreply.github.com>

Rucha0901 and others added 25 commits May 22, 2026 13:29

fixed the inverted slider (magic-peach#749)

ab2175f

Co-authored-by: Akanksha Trehun <146705736+magic-peach@users.noreply.github.com>

fix: remove duplicate file format text in upload area (magic-peach#777)

f573f7a

* fix: remove duplicate file format text in upload area * fix: add unique page titles for /privacy and /contact pages --------- Co-authored-by: Akanksha Trehun <146705736+magic-peach@users.noreply.github.com>

fix: increase extractMetadata timeout from 500ms to 5s (magic-peach#737)

470cc39

Raises the metadata load timeout to 5 s for large/slow-device compatibility and improves the error message. Closes magic-peach#729.

fix: replace NodeJS.Timeout with ReturnType<typeof setTimeout/setInte…

e275436

…rval> (magic-peach#650) Makes timer ref types environment-agnostic, removing the Node.js-specific NodeJS.Timeout type that caused CI errors in browser environments.

fix: terminate FFmpeg instance on component unmount to prevent memory…

1a4b023

… leak (magic-peach#639) Adds a useEffect cleanup that calls terminateFFmpeg() when the editor unmounts, preventing the FFmpeg WebAssembly instance from staying in memory after navigation.

fix: add proper Metadata type and use em-dash in page titles (magic-p…

4e47337

…each#871) Adds the Next.js Metadata TypeScript type to Contact and Privacy pages, and standardises title separators to use an em-dash (—) consistent with the rest of the site.

feat: add hover lift animation to footer feature badges (magic-peach#834

c640286

) Adds a subtle hover animation (translate-y-0.5, accent border, soft glow) to the footer feature badge chips using CSS variables and Tailwind transitions.

feat: add hover scale animation to Star on GitHub button (magic-peach…

a466022

…#810) Adds a subtle hover scale + glow effect to the Star on GitHub button in the header, improving interactivity feedback.

fix: center RESET ALL SETTINGS button in settings panel

710f69d

Closes magic-peach#773.

fix: improve preset button aria-labels to include platform name (magi…

6f6cd05

…c-peach#698) Changes preset button aria-labels from the awkward '9 is to 16 output ratio' format to 'Reels 9:16' style labels that are more meaningful for screen reader users.

fix: GIF export size estimation

dc02978

Fixes inaccurate GIF size prediction. Closes magic-peach#795.

fix: add JS validation for custom preset width/height

280656f

Adds client-side bounds checking (16-7680px) and autocomplete=off to custom width/height inputs. Closes magic-peach#844.

feat: add accessible SVG brand logo to header

a4d3626

Adds a film-strip SVG logo to the header navbar alongside the Reframe wordmark. Closes magic-peach#809.

feat: enable noUncheckedIndexedAccess and fix resulting type errors

01823d3

Enables stricter TypeScript array access checking (noUncheckedIndexedAccess) and fixes all resulting unsafe accesses. Strengthens type safety across the codebase.

perf: optimize thumbnail generation using Blob URLs

684ead0

Switches thumbnail canvas output from base64 data URLs to Blob object URLs, reducing memory footprint. Adds proper cleanup on unmount.

feat: export success sound with mute toggle (magic-peach#706)

4b82d38

Adds a completion chime on export with a mute/unmute toggle button. Accessible (aria-labels on Volume2/VolumeX icons). All CI passing.

feat: activate recipe prop overlay loop in VideoPreview

74795f6

Wires up the framing overlay loop and repositions overlay indicators in VideoPreview.

chore: trigger CI

0c6ab80

:wqfix: remove runtime errors and clean console

e2fac22

git rebase --continue git rebase --continue

progress: fixed most TypeScript errors

970d003

fix: resolved TypeScript errors and build issues

6abaa03

Pravallika21-nama force-pushed the clean-console-log-fix branch from aa072c4 to 6abaa03 Compare May 22, 2026 08:22

github-actions Bot added the level:advanced Advanced level - 55 pts label May 22, 2026

Merge branch 'main' into clean-console-log-fix

899c5ba

Pravallika21-nama mentioned this pull request May 23, 2026

fix: remove runtime errors and clean console #918

Open

4 tasks

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

fix: remove leftover console log from useVideoEditor#830

fix: remove leftover console log from useVideoEditor#830
Pravallika21-nama wants to merge 39 commits into
magic-peach:mainfrom
Pravallika21-nama:clean-console-log-fix

Pravallika21-nama commented May 21, 2026

Uh oh!

vercel Bot commented May 21, 2026

Uh oh!

chatgpt-codex-connector Bot commented May 21, 2026

Uh oh!

github-actions Bot commented May 21, 2026

Uh oh!

github-actions Bot commented May 21, 2026 •

edited

Loading

Uh oh!

Pravallika21-nama commented May 21, 2026 •

edited

Loading

Uh oh!

magic-peach commented May 21, 2026

Uh oh!

Pravallika21-nama commented May 21, 2026

Uh oh!

Pravallika21-nama commented May 21, 2026

Uh oh!

Pravallika21-nama commented May 21, 2026

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

19 participants

Conversation

Pravallika21-nama commented May 21, 2026

Description

Related Issue

Type of Contribution

Participant Info

Screen Recording

Checklist

Uh oh!

vercel Bot commented May 21, 2026

Uh oh!

chatgpt-codex-connector Bot commented May 21, 2026

Uh oh!

github-actions Bot commented May 21, 2026

👋 Thanks for your PR, @Pravallika21-nama!

What happens next

Quick checklist

Useful links

Uh oh!

github-actions Bot commented May 21, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

✅ PR Format Check Passed — @Pravallika21-nama

Uh oh!

Pravallika21-nama commented May 21, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

magic-peach commented May 21, 2026

Uh oh!

Pravallika21-nama commented May 21, 2026

Uh oh!

Pravallika21-nama commented May 21, 2026

Uh oh!

Pravallika21-nama commented May 21, 2026

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

19 participants

github-actions Bot commented May 21, 2026 •

edited

Loading

Pravallika21-nama commented May 21, 2026 •

edited

Loading