fix: check post-finalize actions on what they modified

[Dodecahedr0x]

What changed

Closes #42

Executes actions first, then run the post finalize check

[coderabbitai]

📝 Walkthrough

Walkthrough

Post-finalize actions now execute before account mutation validation. Dirty accounts are rejected only when they are not writable under AccountMode and DirtyMarkers, while transient and closed lifecycle transitions remain permitted.

Changes

Post-finalize validation

Layer / File(s)	Summary
Action ordering and mode-aware writability programs/magic-root-program/src/post_finalize.rs	Post-finalize actions execute before account validation. Dirty accounts are rejected when they are not writable. The private writable predicate permits mutable accounts and marked transient or closed accounts.

Estimated code review effort: 3 (Moderate) | ~15 minutes

Suggested reviewers: bmuddha

🚥 Pre-merge checks | ✅ 4 | ❌ 1

❌ Failed checks (1 inconclusive)

Check name	Status	Explanation	Resolution
Linked Issues check	❓ Inconclusive	The change addresses action ordering and immutable-account validation, but the provided summary does not confirm public-key diagnostics or creation validation preservation.	Verify that rejection diagnostics include the affected account public key and that creation still requires a system-owned, empty target account.

✅ Passed checks (4 passed)

Check name	Status	Explanation
Out of Scope Changes check	✅ Passed	The described changes remain within the linked issue scope and target post-finalize action validation.
Docstring Coverage	✅ Passed	No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check.
Title check	✅ Passed	The title clearly states that post-finalize actions are checked against the changes they make.
Description check	✅ Passed	The description directly explains that actions execute before the post-finalize check and references the related issue.

✨ Finishing Touches

📝 Generate docstrings

• Create stacked PR
• Commit on current branch

🧪 Generate unit tests (beta)

• Create PR with unit tests
• Commit unit tests in branch dode/post-finalize-after-actions

---

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

• X
• Mastodon
• Reddit
• LinkedIn

_{Comment @coderabbitai help to get the list of available commands.}

[bmuddha]

LGTM