Fix duplicate typename__ when type implements multiple interfaces - #1
Draft
magicmark wants to merge 1 commit into
Draft
Fix duplicate typename__ when type implements multiple interfaces#1magicmark wants to merge 1 commit into
magicmark wants to merge 1 commit into
Conversation
When multiple inline fragments (targeting different interfaces a type implements) each select the same field, only keep the first occurrence. Co-Authored-By: Claude <noreply@anthropic.com>
magicmark
force-pushed
the
fix/duplicate-typename-fields
branch
from
July 7, 2026 21:46
8c93608 to
22e36c5
Compare
magicmark
force-pushed
the
fix/duplicate-typename-dedup
branch
from
July 7, 2026 21:46
bbefd8b to
3f3b17f
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes the bug from the xfail test —
_resolve_selection_setmerges fields from all matching inline fragments, so when a type implements interfaces Bar and Baz and both spreads select__typename, you get it twice.The fix deduplicates fields by name at the end of
_resolve_selection_set, keeping the first occurrence. All 924 existing tests pass unchanged.