Conversation
Contributor
There was a problem hiding this comment.
Pull request overview
Updates GitHub Actions workflow dependencies to newer major versions and adjusts CI setup to use Corepack for pnpm management.
Changes:
- Bump
actions/checkout,actions/setup-node, andactions/upload-artifactto@v5. - Remove
pnpm/action-setupusage in CI and add acorepack enablestep before running pnpm commands.
Reviewed changes
Copilot reviewed 2 out of 2 changed files in this pull request and generated 1 comment.
| File | Description |
|---|---|
| .github/workflows/copilot-setup-steps.yml | Upgrades actions/checkout to @v5. |
| .github/workflows/ci.yml | Upgrades key actions to @v5 and switches pnpm setup to Corepack. |
Comments suppressed due to low confidence (1)
.github/workflows/ci.yml:70
- Same issue as in the
testjob:setup-nodeis asked to cache pnpm deps before pnpm is made available (corepack is enabled only afterwards). This can break the job or prevent caching. Install/activate pnpm beforeactions/setup-nodecaching, or disablecache: "pnpm"and cache pnpm’s store later once corepack is enabled.
- name: Setup Node.js
uses: actions/setup-node@v5
with:
node-version-file: ".node-version"
cache: "pnpm"
cache-dependency-path: "pnpm-lock.yaml"
- name: Enable corepack
run: corepack enable
You can also share your feedback on Copilot code review. Take the survey.
* Initial plan * fix: move corepack enable before setup-node in CI workflow Co-authored-by: mahata <23497+mahata@users.noreply.github.com> --------- Co-authored-by: copilot-swe-agent[bot] <198982749+Copilot@users.noreply.github.com> Co-authored-by: mahata <23497+mahata@users.noreply.github.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Upgrade the GitHub Actions used in the workflow to version 5 for improved performance and features. This includes updating the checkout, setup-node, and upload-artifact actions. Additionally, enable corepack for better package management.