Skip to content

test(emailAuth): add unit tests for success flows and conflict paths#121

Merged
mahata merged 2 commits intofeat/email-signupfrom
copilot/sub-pr-120
Mar 25, 2026
Merged

test(emailAuth): add unit tests for success flows and conflict paths#121
mahata merged 2 commits intofeat/email-signupfrom
copilot/sub-pr-120

Conversation

Copy link
Copy Markdown
Contributor

Copilot AI commented Mar 25, 2026

The emailAuth route tests only covered validation/error paths, leaving the primary success flows and conflict cases untested.

Changes

  • Refactored mock setup — replaced inline vi.fn() chains with vi.hoisted()-extracted handles (mockLimit, mockVerifyPassword, mockInsertValues) so individual tests can override return values via mockResolvedValueOnce

  • Added missing test cases:

    • POST /auth/login — user found but password wrong → 401
    • POST /auth/login — valid credentials → 302 to /
    • POST /auth/register — email already in DB → 409
    • POST /auth/register — all valid → 302 to /, asserts db.insert().values() called
it("should redirect to / on successful login", async () => {
  mockLimit.mockResolvedValueOnce([{ email: "user@example.com", name: "Test User", passwordHash: "salt:hash" }]);
  mockVerifyPassword.mockResolvedValueOnce(true);
  // ...
  expect(response.status).toBe(302);
  expect(response.headers.get("Location")).toBe("/");
});

💬 Send tasks to Copilot coding agent from Slack and Teams to turn conversations into code. Copilot posts an update in your thread when it's finished.

Copilot AI changed the title [WIP] [WIP] Address feedback on email authentication implementation PR test(emailAuth): add unit tests for success flows and conflict paths Mar 25, 2026
Copilot AI requested a review from mahata March 25, 2026 12:09
@mahata mahata marked this pull request as ready for review March 25, 2026 12:42
@mahata mahata merged commit 59f5364 into feat/email-signup Mar 25, 2026
@mahata mahata deleted the copilot/sub-pr-120 branch March 25, 2026 12:43
mahata added a commit that referenced this pull request Mar 25, 2026
* feat(auth): implement email authentication with login and registration routes

* Apply suggestion from @Copilot

Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>

* test(emailAuth): add unit tests for success flows and conflict paths (#121)

* Initial plan

* test(emailAuth): add unit tests for success flows and conflict paths

Co-authored-by: mahata <23497+mahata@users.noreply.github.com>
Agent-Logs-Url: https://github.com/mahata/mlack/sessions/e8292715-c961-480d-8c1a-490e2db65f9a

---------

Co-authored-by: copilot-swe-agent[bot] <198982749+Copilot@users.noreply.github.com>
Co-authored-by: mahata <23497+mahata@users.noreply.github.com>

* fix: CSRF protection for email auth form endpoints (#122)

* Initial plan

* fix: add CSRF protection for email auth form endpoints

Co-authored-by: mahata <23497+mahata@users.noreply.github.com>
Agent-Logs-Url: https://github.com/mahata/mlack/sessions/81a07abc-5f9a-4910-8bdc-71951fdb71bb

---------

Co-authored-by: copilot-swe-agent[bot] <198982749+Copilot@users.noreply.github.com>
Co-authored-by: mahata <23497+mahata@users.noreply.github.com>

* fix: add missing Origin header in POST tests blocked by CSRF middleware (#124)

* Initial plan

* fix: add Origin header to POST tests blocked by CSRF middleware

Co-authored-by: mahata <23497+mahata@users.noreply.github.com>
Agent-Logs-Url: https://github.com/mahata/mlack/sessions/86a80766-f33f-4962-ba8e-c5907a70e520

---------

Co-authored-by: copilot-swe-agent[bot] <198982749+Copilot@users.noreply.github.com>
Co-authored-by: mahata <23497+mahata@users.noreply.github.com>

* Initial plan (#125)

Co-authored-by: copilot-swe-agent[bot] <198982749+Copilot@users.noreply.github.com>

* fix: add Origin header to E2E test requests blocked by CSRF middleware (#126)

* Initial plan

* fix: add Origin header to E2E test requests blocked by CSRF middleware

Co-authored-by: mahata <23497+mahata@users.noreply.github.com>
Agent-Logs-Url: https://github.com/mahata/mlack/sessions/edbeed38-429c-4f9f-beb6-cf8d58dc7ec4

---------

Co-authored-by: copilot-swe-agent[bot] <198982749+Copilot@users.noreply.github.com>
Co-authored-by: mahata <23497+mahata@users.noreply.github.com>

---------

Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>
Co-authored-by: Copilot <198982749+Copilot@users.noreply.github.com>
Co-authored-by: mahata <23497+mahata@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants