fix: add missing h1 heading to ChatPage#134
Merged
mahata merged 2 commits intofeat/channelsfrom Mar 26, 2026
Merged
Conversation
Agent-Logs-Url: https://github.com/mahata/mlack/sessions/00133b70-6800-4b81-9ad8-fb4b19a6e07c Co-authored-by: mahata <23497+mahata@users.noreply.github.com>
Copilot
AI
changed the title
[WIP] Fix the failing GitHub Actions workflow e2e
fix: add missing h1 heading to ChatPage
Mar 26, 2026
mahata
added a commit
that referenced
this pull request
Mar 26, 2026
…aging (#130) * feat: add Slack-like channels with sidebar UI and channel-scoped messaging Add a Channel feature where each message belongs to a single channel and channels can have multiple members. All users are auto-joined to #general. - Add channels and channel_members tables with migration (seeds #general, backfills existing messages) - Add channel CRUD API routes (list, create, join, leave) with 14 tests - Update messages API to require channelId query parameter - Switch WebSocket protocol from plain text to JSON with channel-scoped broadcast (only channel members receive messages) - Add dark-themed Slack-like UI with channel sidebar, create channel modal, join/leave functionality - Auto-join users to #general on page visit - Update all existing tests for new HTML structure and API changes * Update hono/routes/messages.ts Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com> * Update hono/static/ChatPage.ts Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com> * feat: add composite index on messages(channel_id, created_at) (#132) * Initial plan * feat: add composite index on (channel_id, created_at) to messages table Agent-Logs-Url: https://github.com/mahata/mlack/sessions/d188e657-de69-47e9-9277-0c7227faaffd Co-authored-by: mahata <23497+mahata@users.noreply.github.com> --------- Co-authored-by: copilot-swe-agent[bot] <198982749+Copilot@users.noreply.github.com> Co-authored-by: mahata <23497+mahata@users.noreply.github.com> * [WIP] Fix the failing GitHub Actions workflow e2e (#134) * Initial plan * fix: add h1 Hello, world! heading to ChatPage for e2e test Agent-Logs-Url: https://github.com/mahata/mlack/sessions/00133b70-6800-4b81-9ad8-fb4b19a6e07c Co-authored-by: mahata <23497+mahata@users.noreply.github.com> --------- Co-authored-by: copilot-swe-agent[bot] <198982749+Copilot@users.noreply.github.com> Co-authored-by: mahata <23497+mahata@users.noreply.github.com> --------- Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com> Co-authored-by: Copilot <198982749+Copilot@users.noreply.github.com> Co-authored-by: mahata <23497+mahata@users.noreply.github.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The e2e test
App renders Hello, world! textwas failing becauseChatPage.tsxhad noh1element — onlyh2elements — while the test expectedlocator('h1')to contain"Hello, world!".Changes
hono/components/ChatPage.tsx: Added<h1>Hello, world!</h1>inside.chat-headerhono/components/ChatPage.test.ts: Added unit test asserting theh1heading is present in rendered HTMLOriginal prompt
🔒 GitHub Advanced Security automatically protects Copilot coding agent pull requests. You can protect all pull requests by enabling Advanced Security for your repositories. Learn more about Advanced Security.