Make WebSocket URL configurable using data attributes#41
Merged
Conversation
Co-authored-by: mahata <23497+mahata@users.noreply.github.com>
Copilot
AI
changed the title
[WIP] Make WebSocket URL configurable in ChatPage.ts
Make WebSocket URL configurable using data attributes
Jul 10, 2025
mahata
approved these changes
Jul 10, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The WebSocket URL in ChatPage.ts was hardcoded to
ws://localhost:3000/ws, which only worked in development environments. This change makes the WebSocket URL configurable to support deployment in different environments (development, staging, production).Changes Made
Server-side (ChatPage.tsx):
wsUrlparameter toChatPagecomponentdata-ws-urlattribute to pass WebSocket URL from server to clientws://localhost:3000/wsfor backward compatibilityRoute handler (index.tsx):
ws://for HTTP requests,wss://for HTTPS requestsClient-side (ChatPage.ts):
data-ws-urlattribute instead of hardcoded valueTechnical Implementation
The solution uses the existing data attribute pattern for consistency with the current architecture:
Environment Support
This change enables the application to work across different deployment scenarios:
ws://localhost:3000/wsws://staging.myapp.com/wswss://myapp.com/ws(automatically uses secure WebSocket for HTTPS)Testing
- ✅ All existing tests pass (17/17)
- ✅ Added comprehensive tests for WebSocket URL configuration
- ✅ Manual testing confirms WebSocket connection works correctly
- ✅ Verified message sending/receiving functionality
The screenshot shows the chat interface with a successful WebSocket connection (green "Connected" status), demonstrating that the configurable WebSocket URL works correctly.
Fixes #40.
💡 You can make Copilot smarter by setting up custom instructions, customizing its development environment and configuring Model Context Protocol (MCP) servers. Learn more Copilot coding agent tips in the docs.