Refactor WebSocket URL construction to prioritize X-Forwarded-Proto header#44
Merged
Refactor WebSocket URL construction to prioritize X-Forwarded-Proto header#44
Conversation
Contributor
There was a problem hiding this comment.
Pull Request Overview
This pull request refactors the WebSocket URL construction logic to prioritize the X-Forwarded-Proto header when determining the protocol for WebSocket connections. This improvement enhances support for applications running behind reverse proxies that handle HTTPS termination.
- Changed protocol detection from URL-based to header-based approach using
X-Forwarded-Proto - Updated test case to verify the new header-based protocol detection logic
Reviewed Changes
Copilot reviewed 2 out of 2 changed files in this pull request and generated 1 comment.
| File | Description |
|---|---|
| hono/routes/index.tsx | Modified WebSocket URL construction to check X-Forwarded-Proto header first |
| hono/routes/index.test.tsx | Updated test to verify header-based protocol detection instead of URL-based |
Comments suppressed due to low confidence (1)
hono/routes/index.test.tsx:37
- The test coverage is incomplete. The original test for direct HTTPS requests was removed, but there should be tests covering: 1) direct HTTPS requests without proxy headers, 2) X-Forwarded-Proto with non-https values, and 3) missing X-Forwarded-Proto header scenarios.
it("should construct correct WebSocket URL when X-Forwarded-Proto header is https", async () => {
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This pull request refines the logic for constructing WebSocket URLs in the
hono/routes/index.tsxfile and updates the corresponding test cases inhono/routes/index.test.tsx. The changes ensure that theX-Forwarded-Protoheader is prioritized when determining the protocol, improving support for proxied HTTPS requests.