Conversation
There was a problem hiding this comment.
Pull request overview
This release updates the SDK’s networking and provisioning discovery surfaces by replacing floating-IP operations with network pool operations, and by adding resource-pool/service-plan discovery helpers to support permission-safe provisioning flows.
Changes:
- Replace floating-IP listing/allocation/release with network pool and pool-IP listing APIs and corresponding models.
- Add provisioning discovery helpers for service plans and resource pools, plus resource-pool ID normalization for instance creation.
- Update README + docs/api-reference guides accordingly and bump version to v0.2.18.
Reviewed changes
Copilot reviewed 13 out of 13 changed files in this pull request and generated 3 comments.
Show a summary per file
| File | Description |
|---|---|
| tests/test_networks.py | Updates tests to validate the new network pool endpoints/models. |
| src/mtn_cloud/resources/networks.py | Replaces floating-IP methods with list_pools, get_pool, list_pool_ips. |
| src/mtn_cloud/resources/instances.py | Adds provisioning discovery helpers and normalizes resource_pool_id in create(). |
| src/mtn_cloud/models/resource_pool.py | Introduces ResourcePool model for provisioning discovery. |
| src/mtn_cloud/models/network.py | Adds NetworkPool, NetworkPoolIp, NetworkPoolRange models (removes floating-IP model). |
| src/mtn_cloud/models/init.py | Exports the new network pool + resource pool models. |
| src/mtn_cloud/_version.py | Bumps package version to 0.2.18. |
| README.md | Documents permission-safe discovery steps and resource pool usage in provisioning. |
| docs/networking.md | Reframes public connectivity guidance and documents network pools instead of floating-IPs. |
| docs/instances.md | Documents resource pool discovery + service plan discovery and updated create flow. |
| docs/api-reference/networks.md | Updates API reference to network pools and notes floating-IP restriction. |
| docs/api-reference/instances.md | Updates create() signature and adds provisioning discovery API reference. |
| docs/api-overview.md | Updates API overview examples to include resource pool discovery. |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Pull Request
Description
Brief description of what this PR does.
Type of Change
Checklist
ruff checkandruff formatmypyand fixed any type errorsRelated Issues
Fixes #(issue number)
Additional Notes
Any additional information that reviewers should know.