Report DNS server failures as temperror, not absence - #3
Merged
Conversation
Resolv collapses SERVFAIL and REFUSED into the same empty answer as NXDOMAIN, so a nameserver that refused to speak was read as a domain that published nothing — SPF/DMARC none, DKIM permerror. Call sites already handled ServerFailure; the resolver never raised it. Switch the default resolver to dnsruby, which reports each rcode as its own class. SERVFAIL and REFUSED become temperror; NXDOMAIN and NODATA stay absence. Caching and DNSSEC stay off.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
none/ DKIMpermerror) by replacing stdlibResolvwith dnsruby, which surfaces each rcode distinctly asServerFailure→temperrordomainname, joined TXT strings, sorted MX, lowercased IPv6