MT-23076: support api token expiration in create and reset - #77
Draft
oshchyhol wants to merge 4 commits into
Draft
MT-23076: support api token expiration in create and reset#77oshchyhol wants to merge 4 commits into
oshchyhol wants to merge 4 commits into
Conversation
|
Important Review skippedDraft detected. Please check the settings in the CodeRabbit UI or the ⚙️ Run configurationConfiguration used: Organization UI Review profile: CHILL Plan: Pro Plus Run ID: You can disable this status message by setting the Use the checkbox below for a quick retry:
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
This was referenced Aug 7, 2026
Draft
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Motivation
MT-23076
The API token endpoints now support an
expires_atattribute. This exposes it in the Python SDK so tokens can be created or reset with an explicit expiry, with no expiry, or with the server default.Changes
createApiToken:CreateApiTokenParamsgains an optionalexpires_at(ISO 8601 date-time, nullable). Omitted – key absent from the request body (server default, a 1-year default is being rolled out); explicitNone–"expires_at": null(never expires); string – sent as isresetApiToken: the request body is now optional per the spec; newResetApiTokenParamswith the sameexpires_atfield, andreset()accepts an optionaltoken_paramsargument. Without it, the request still has no body, byte-identical to beforeUNSETsentinel (UnsetTypeinmailtrap/models/common.py) keeps "field omitted" distinct from an explicitNone;RequestParams.api_datadropsUNSETvalues. Exported asmt.UNSETtogether withmt.ResetApiTokenParamsAPIErrorexamples/general/api_tokens.pyextended with expiration usageHow to test
api_tokens.create(account_id, mt.CreateApiTokenParams(name="My token"))– request body has noexpires_atkey, token is created exactly as before the changeapi_tokens.create(account_id, mt.CreateApiTokenParams(name="My token", expires_at=None))– request body contains"expires_at": null, response hasexpires_at: None(never expires)api_tokens.create(account_id, mt.CreateApiTokenParams(name="My token", expires_at="2027-06-01T00:00:00Z"))– request body contains that date-time, response echoes itcreatewith a past date (or one more than 5 years ahead) – SDK raisesAPIErrorwith the server's 422 messageapi_tokens.reset(account_id, token_id)without params – request has no body (same as before), reset works unchangedapi_tokens.reset(account_id, token_id, token_params=mt.ResetApiTokenParams(expires_at=None))– request body is{"expires_at": null}, new token never expiresapi_tokens.reset(account_id, token_id, token_params=mt.ResetApiTokenParams(expires_at="2027-06-01T00:00:00Z"))– request body contains that date-timeCompanion PRs
Caveat: release/merge only after falcon deploys MT-23076 and zap_api_token_expiration is enabled in production.