feat(dev-server): keep sidebar folder label on one line - #1817
Conversation
Long group paths now stay on a single line with native horizontal scroll (no visible scrollbar) instead of wrapping. A directive-driven mask fades the left/right edges only when the label overflows in that direction, signaling there's more to scroll. Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com>
|
No actionable comments were generated in the recent review. 🎉 ℹ️ Recent review info⚙️ Run configurationConfiguration used: Organization UI Review profile: CHILL Plan: Pro Plus Run ID: 📒 Files selected for processing (1)
🚧 Files skipped from review as they are similar to previous changes (1)
📝 WalkthroughWalkthroughThe UI adds a ChangesSidebar scroll fading
Estimated code review effort: 2 (Simple) | ~10 minutes Sequence Diagram(s)sequenceDiagram
participant DirectoryLabel
participant vFade
participant Window
participant ResizeObserver
DirectoryLabel->>vFade: mount and update fade variables
DirectoryLabel->>vFade: emit scroll events
Window->>vFade: emit resize events
ResizeObserver->>vFade: report size changes
vFade->>DirectoryLabel: update horizontal edge fade state
🚥 Pre-merge checks | ✅ 5✅ Passed checks (5 passed)
✨ Finishing Touches🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
There was a problem hiding this comment.
Actionable comments posted: 1
🤖 Prompt for all review comments with AI agents
Verify each finding against current code. Fix only still-valid issues, skip the
rest with a brief reason, keep changes minimal, and validate.
Inline comments:
In `@src/server/ui/App.vue`:
- Around line 293-312: Update the vFade directive to create a ResizeObserver for
el that invokes the existing fade recalculation callback whenever the element
resizes, and store the observer on the element for cleanup. In unmounted,
disconnect that observer while preserving the existing scroll and window resize
listener cleanup.
🪄 Autofix (Beta)
Fix all unresolved CodeRabbit comments on this PR:
- Push a commit to this branch (recommended)
- Create a new PR with the fixes
ℹ️ Review info
⚙️ Run configuration
Configuration used: Organization UI
Review profile: CHILL
Plan: Pro Plus
Run ID: e9393eaf-38bd-4ff3-ab43-d8524e35c26f
📒 Files selected for processing (2)
src/server/ui/App.vuesrc/server/ui/main.css
Observe the label element with a ResizeObserver so the edge fades update when the sidebar resizes without a window resize event. Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com>
What
Long folder/group paths in the dev server sidebar wrapped to multiple lines. Now they stay on a single line with native horizontal scroll (scrollbar hidden), and edge fades signal when there's more to scroll.
Changes
src/server/ui/App.vue— the group label text renders in a scrollable<span>with av-fadedirective.src/server/ui/main.css— newscrollbar-hideandfade-scrollutilities.Behavior
Before
After
Summary by CodeRabbit