Skip to content

ci: fail the review job when the reviewer errors#41

Merged
andybons merged 1 commit into
mainfrom
ci/fail-on-review-error
Jul 9, 2026
Merged

ci: fail the review job when the reviewer errors#41
andybons merged 1 commit into
mainfrom
ci/fail-on-review-error

Conversation

@andybons

@andybons andybons commented Jul 9, 2026

Copy link
Copy Markdown
Contributor

Summary

Closes the false-green class observed repeatedly: when the review action's model call fails (API error / usage-window cap), it writes a placeholder comment and records is_error in its execution output, yet the job exits success — producing a mergeable-looking PR with zero findings that was never reviewed. A verification step now inspects the execution-output JSON and fails the job (red check) when the review errored, so an exhausted usage window shows up as a visible failure instead of a silent pass. Dependency-free (jq, preinstalled).

Goal-supervised box build (ses_2621420c5a72d03b), box-pushed.

🤖 Generated with Claude Code

@andybons

andybons commented Jul 9, 2026

Copy link
Copy Markdown
Contributor Author

Merging with the claude-review check red — that red is this PR's own verify step working as designed: the review action skips itself on PRs that modify the workflow file (supply-chain protection; it requires the file to match the default branch), so workflow PRs can never self-review. Coordinator review of the 28-line diff performed directly: fail-closed on missing output, defensive object/array handling, if: always(), correct is_error check. Test job green. The action's own log says the workflow activates on merge.

@andybons andybons merged commit 3f4b440 into main Jul 9, 2026
1 of 2 checks passed
@andybons andybons deleted the ci/fail-on-review-error branch July 9, 2026 15:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant