ci: fail the review job when the reviewer errors#41
Merged
Conversation
Contributor
Author
|
Merging with the claude-review check red — that red is this PR's own verify step working as designed: the review action skips itself on PRs that modify the workflow file (supply-chain protection; it requires the file to match the default branch), so workflow PRs can never self-review. Coordinator review of the 28-line diff performed directly: fail-closed on missing output, defensive object/array handling, if: always(), correct is_error check. Test job green. The action's own log says the workflow activates on merge. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Closes the false-green class observed repeatedly: when the review action's model call fails (API error / usage-window cap), it writes a placeholder comment and records
is_errorin its execution output, yet the job exits success — producing a mergeable-looking PR with zero findings that was never reviewed. A verification step now inspects the execution-output JSON and fails the job (red check) when the review errored, so an exhausted usage window shows up as a visible failure instead of a silent pass. Dependency-free (jq, preinstalled).Goal-supervised box build (
ses_2621420c5a72d03b), box-pushed.🤖 Generated with Claude Code