Add temperature beta and remove sig_dt#4
Merged
Conversation
The Fausser paper describes the exponent on the ratio of the sampled radius to the pedestal radius as being a variable beta_T, but the current implementation fixes this at a value of 2. This commit makes the beta_T value variable and sets the default value of 6.0 as used in the paper.
DanShort12
referenced
this pull request
in DanShort12/parametric-plasma-source-old
Jul 25, 2020
Build python in setup
Closed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR introduces a new ion_temperature_beta parameter, which reflects beta_T from the Fausser paper. The parameter is given a default value of 6 (corresponding to table 1 of the paper) and used as the exponent for the ratio of the sampled radius to the pedestal radius when calculating the ion temperature within the pedestal.
Also removes an unused variable (sig_dt), which was producing a compiler warning.