Skip to content

combinations section in macro.json is unsued #422

Description

@Shatur

I continue to research how MPFB2 works to integrate its pipeline into my FOSS game, and it looks like combinations sections is never used. Is this correct? It looks like combinations are actually hardcoded in https://github.com/makehumancommunity/mpfb2/blob/master/src/mpfb/services/targetservice.py and macro.json is actually used only to read determine interpolation regions and component weights?

I'd suggest to cleanup the redundant information from all file formats to make things easier to understand. Alternatively, it would be great to make things more data-driven to let users define their own macro targets.

Metadata

Metadata

Assignees

No one assigned

    Labels

    bugSomething isn't working

    Type

    No type

    Projects

    No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions