Skip to content

fix(sms-bridge): preserve max-media value format - #81

Merged
xnoto merged 1 commit into
mainfrom
fix/sms-bridge-config-number-format
Sep 4, 2026
Merged

fix(sms-bridge): preserve max-media value format#81
xnoto merged 1 commit into
mainfrom
fix/sms-bridge-config-number-format

Conversation

@xnoto

@xnoto xnoto commented Sep 4, 2026

Copy link
Copy Markdown
Contributor

Summary

Fixes the bridge worker startup crash observed during the first GitOps rollout. Helm renders numeric config.maxMediaBytes through a ConfigMap; the unquoted YAML value became scientific notation (5.24288e+06), which the worker correctly rejects as a non-integer. The default is now the exact decimal string "5242880".

Also corrects the bridge chart's RWO PVC sync-wave guidance: with WaitForFirstConsumer storage, the PVC must share wave 2 with its Deployment rather than block it in an earlier wave.

Fixes #

None — rollout defect found during operator verification.

Type of change

  • Bug fix
  • Feature / enhancement
  • Documentation
  • Infrastructure (OpenTofu root or module)
  • GitOps desired state (manifests, kustomize, charts, SOPS/KSOPS secrets)
  • Container image
  • CI / reusable workflow
  • Refactor / cleanup
  • Breaking change

Validation

No local Helm or repository checks were run or claimed. CI validated repository hygiene, Helm rendering, changed-chart detection, and packaging of opencode-sms-bridge; PR runs do not publish an OCI artifact.

Impact and rollout

Producer changed: makeitworkcloud/charts owns the bridge Deployment and ConfigMap defaults. This PR bumps immutable OCI chart version 0.1.1 to 0.1.2; it does not change the bridge image, secrets, PVC, Service, or TunnelBinding.

Consumer unchanged: makeitworkcloud/kustomize-cluster currently pins opencode-sms-bridge 0.1.1 in workloads/apps/opencode-sms-bridge-app.yaml. Its existing post-publish automation supports only opencode-server, so after this PR is merged and the package opencode-sms-bridge main job confirms publication, a separate reviewed GitOps PR must pin 0.1.2. That GitOps PR will need its own cluster CI, merge, root/child reconciliation, pod health, TunnelBinding, and endpoint verification. Twilio webhooks remain unchanged.

Rollback: do not overwrite an OCI version. If 0.1.2 proves unsuitable before consumer selection, leave the GitOps pin unchanged; after selection, correct with a new immutable chart version rather than retagging a release.

Safety and secrets

  • Contains no plaintext secrets, decrypted SOPS values, state files, kubeconfigs, tokens, or private endpoints
  • No local OpenTofu init/plan/apply/destroy/import/state operations were run or claimed — plans come from pull-request checks
  • Breaking or irreversible effects are described above with rollback notes

GitHub Advanced Security secret scanning is unavailable for this repository. The three-file diff was manually reviewed; it contains only a chart version, a non-sensitive decimal limit, and documentation.

AI-assisted change: an OpenCode agent materially produced this change; reviewers should verify the rendered ConfigMap value and cross-repository version-pin sequence.

@github-actions

github-actions Bot commented Sep 4, 2026

Copy link
Copy Markdown

Chart CI passed

Repository hygiene and Helm validation passed. View the workflow run.

@xnoto
xnoto merged commit a919d86 into main Sep 4, 2026
4 checks passed
@xnoto
xnoto deleted the fix/sms-bridge-config-number-format branch September 4, 2026 21:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant