fix(sms-bridge): preserve max-media value format - #81
Merged
Conversation
Chart CI passedRepository hygiene and Helm validation passed. View the workflow run. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Fixes the bridge worker startup crash observed during the first GitOps rollout. Helm renders numeric
config.maxMediaBytesthrough a ConfigMap; the unquoted YAML value became scientific notation (5.24288e+06), which the worker correctly rejects as a non-integer. The default is now the exact decimal string"5242880".Also corrects the bridge chart's RWO PVC sync-wave guidance: with
WaitForFirstConsumerstorage, the PVC must share wave2with its Deployment rather than block it in an earlier wave.Fixes #
None — rollout defect found during operator verification.
Type of change
Validation
test,detect, andpackage opencode-sms-bridgesucceeded.No local Helm or repository checks were run or claimed. CI validated repository hygiene, Helm rendering, changed-chart detection, and packaging of
opencode-sms-bridge; PR runs do not publish an OCI artifact.Impact and rollout
Producer changed:
makeitworkcloud/chartsowns the bridge Deployment and ConfigMap defaults. This PR bumps immutable OCI chart version0.1.1to0.1.2; it does not change the bridge image, secrets, PVC, Service, orTunnelBinding.Consumer unchanged:
makeitworkcloud/kustomize-clustercurrently pinsopencode-sms-bridge0.1.1inworkloads/apps/opencode-sms-bridge-app.yaml. Its existing post-publish automation supports onlyopencode-server, so after this PR is merged and thepackage opencode-sms-bridgemain job confirms publication, a separate reviewed GitOps PR must pin0.1.2. That GitOps PR will need its own cluster CI, merge, root/child reconciliation, pod health, TunnelBinding, and endpoint verification. Twilio webhooks remain unchanged.Rollback: do not overwrite an OCI version. If
0.1.2proves unsuitable before consumer selection, leave the GitOps pin unchanged; after selection, correct with a new immutable chart version rather than retagging a release.Safety and secrets
GitHub Advanced Security secret scanning is unavailable for this repository. The three-file diff was manually reviewed; it contains only a chart version, a non-sensitive decimal limit, and documentation.
AI-assisted change: an OpenCode agent materially produced this change; reviewers should verify the rendered ConfigMap value and cross-repository version-pin sequence.