fix: allow chart updater App through protected merge - #50
Merged
Conversation
Contributor
OpenTofu TestOpenTofu test passed. View run output |
Contributor
OpenTofu PlanOpenTofu plan passed. View run outputOpenTofu will perform the following actions:
# github_branch_protection.protections["kustomize-cluster"] will be updated in-place
~ resource "github_branch_protection" "protections" {
id = "BPR_kwDOQsxTyc4EPi_g"
# (10 unchanged attributes hidden)
~ restrict_pushes {
~ push_allowances = [
+ "A_kwHOC6ciJM4ASGn_",
# (1 unchanged element hidden)
]
# (1 unchanged attribute hidden)
}
# (2 unchanged blocks hidden)
}
Plan: 0 to add, 1 to change, 0 to destroy.
OpenTofu will perform the following actions:
# github_branch_protection.protections["kustomize-cluster"] will be updated in-place
~ resource "github_branch_protection" "protections" {
id = "BPR_kwDOQsxTyc4EPi_g"
# (10 unchanged attributes hidden)
~ restrict_pushes {
~ push_allowances = [
+ "A_kwHOC6ciJM4ASGn_",
# (1 unchanged element hidden)
]
# (1 unchanged attribute hidden)
}
# (2 unchanged blocks hidden)
}
Plan: 0 to add, 1 to change, 0 to destroy. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
makeitworkbotGitHub App through the provider-supportedgithub_appdata sourcekustomize-cluster'srestrict_pushes.push_allowancestestcheck, zero-approval policy, admin-team allowance, linear history, and force-push prohibitionRoot cause
The first real auto-merge release created
kustomize-cluster#120and passed its requiredtestcheck, but charts run 33336120370 failed while enabling auto-merge:allow_auto_mergewas already applied successfully. The remaining restriction isgithub_branch_protection.protections["kustomize-cluster"].restrict_pushes, which currently allows only the organization admins team.The updater App installation and token permissions are independently proven: the same run created the branch, commit, and pull request using Contents and Pull requests write permissions.
Safety and scope
kustomize-cluster.Expected plan
data.github_app.chart_updaterfor slugmakeitworkbot.github_branch_protection.protections["kustomize-cluster"]in place by adding one App node ID torestrict_pushes.push_allowances.PR CI plan is authoritative. No local init, validation, plan, apply, import, state, or secret operation was run from the shared server. The
agent-knowledgediscovery revision used was299e833e2b9817c56f6cbd27e4bc2fe156e83a45.