Skip to content

Build improvements#198

Merged
jessehartloff merged 2 commits intodevelopfrom
build-improvements
Feb 15, 2025
Merged

Build improvements#198
jessehartloff merged 2 commits intodevelopfrom
build-improvements

Conversation

@RA341
Copy link
Copy Markdown
Collaborator

@RA341 RA341 commented Feb 2, 2025

Proposed changes


I noticed some redundant stuff in the compose files so

I refactored the docker build

  1. combined the nginx and client build into a single image

  2. removed config image (since it is already a part of the API build)

  3. cleaned up docker-compose files and removed package.json which was added by accident

also refactored the CI config

Types of changes


What types of changes does your code introduce?
Put an x in the boxes that apply

  • Bugfix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • Documentation Update (if none of the other choices apply)

Checklist


Put an x in the boxes that apply. You can also fill these out after creating the PR. If you're unsure about any of
them, don't hesitate to ask. This is simply a reminder of what we are going to look for before merging your code.

  • My changeset covers only what is described above (no extraneous changes)
  • Lint and unit tests pass locally with my changes
  • I have added tests that prove my fix is effective or that my feature works
  • I have added necessary documentation (if appropriate)

Further comments


If this is a relatively large or complex change, kick off the discussion by explaining why you chose the solution you
did and what alternatives you considered, etc...

RA341 added 2 commits February 2, 2025 06:48
combined the nginx and client build into a single image

removed config image (since it already a part of the api build)

cleaned up docker compose files and removed package.json which was added by accident
@NicholasMy NicholasMy changed the base branch from main to develop February 12, 2025 16:28
@jessehartloff jessehartloff merged commit 4b015cd into develop Feb 15, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants