Skip to content

#21 - Margin/padding scheme, styling fixes#200

Merged
jessehartloff merged 8 commits intodevelopfrom
styling-improvements
Feb 15, 2025
Merged

#21 - Margin/padding scheme, styling fixes#200
jessehartloff merged 8 commits intodevelopfrom
styling-improvements

Conversation

@dvcabiya
Copy link
Copy Markdown
Contributor

@dvcabiya dvcabiya commented Feb 11, 2025

Proposed changes


Basically just changed margin and padding of elements. You can read over it in excruciating detail below, but overall I just tried to make the units standardized across pages to make future development of the frontend easier and not produce ugly spacing.

  • Home Page
    • Standardized heading vertical margin to 20px
    • Standardized card content padding to 30px
    • Removed margin from h2 elements
    • Updated assignment preview list items:
      • Set padding to 20px 30px to match the course title horizontally
      • Decreased width of Title/Category for each list item to space out each section
  • Course Page
    • Changed header padding to 30px
    • Set border-radius of header and card to 20px to match home page
    • Removed margin from header text, made "Section:" text smaller.
    • Changed button spacing system from each button having margin to container using gap.
    • Changed flex alignment from space-between to flex-start only since that seemed more natural to me, but if that's not something other people like let me know and I can remove it.
    • Centered Category title ("Programming Assignments" no longer sits askew to the right in cards)
  • Global
    • Applied the margin rules discussed to h1 and h2 in global.scss
  • Misc
    (Not story related, I just got carried away at some points, sorry! If these should be a different PR let me know and I can remove them from here)
  • Increased font-weight (500->700) on Navbar logo text and centered it vertically in the Navbar
    • This is in line with the redesigned figma.
  • Changed HTML head title from AutoFour to DevU
  • Added git submodule command required to run docker to README.

Types of changes


What types of changes does your code introduce?
Put an x in the boxes that apply

  • Bugfix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • Documentation Update (if none of the other choices apply)

Checklist


Put an x in the boxes that apply. You can also fill these out after creating the PR. If you're unsure about any of
them, don't hesitate to ask. This is simply a reminder of what we are going to look for before merging your code.

  • My changeset covers only what is described above (no extraneous changes)
  • Lint and unit tests pass locally with my changes
  • I have added tests that prove my fix is effective or that my feature works
    • Check card 21 on Scrum board for task tests.
  • I have added necessary documentation (if appropriate)

Further comments


If this is a relatively large or complex change, kick off the discussion by explaining why you chose the solution you
did and what alternatives you considered, etc...

dvcabiya and others added 7 commits February 4, 2025 13:37
…ned up course page with consistently padded buttons.
…this while setting up. If this ought to be a seperate branch or something let me know
…ing missing space on the course page for assignment due date
…al padding rules, switched heading in assignment creation from h2->h1
…on seperation from internal margin to gap in it's container class
@dvcabiya dvcabiya changed the title #21 Styling improvements #21 - Margin/padding scheme, styling fixes Feb 11, 2025
@dvcabiya dvcabiya marked this pull request as ready for review February 12, 2025 15:37
@jessehartloff jessehartloff merged commit c396064 into develop Feb 15, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants