Conversation
…ost finished category cards
…ingle column), applied 3-column design to homepage, changed homepage behavior to only show assignments that have due dates in the future
… down to 50px when viewport gets small enough, and applied that to pageWrapper and other universal elements.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Proposed changes
Approve this PR BEFORE merging this one.
Small PR, just made it so that page padding is decreased to 50px from 100px when the viewport gets small enough. I applied this to PageWrapper and the Navbar so it should be largely universally applied aside from pages which overwrite the PageWrapper's padding defaults. I did branch this off of redesigned-coursepage (sorry for not branching off develop) only because I made so many changes there that it would just introduce a bunch of merge conflicts if I tried to do them twice, so please review that PR before merging this one.
Types of changes
Checklist
Put an
xin the boxes that apply. You can also fill these out after creating the PR. If you're unsure about any ofthem, don't hesitate to ask. This is simply a reminder of what we are going to look for before merging your code.