Skip to content

Conversation

@NeemZ16
Copy link
Member

@NeemZ16 NeemZ16 commented Mar 3, 2025

Proposed changes


Added global styling for modals, created modal component in shared/layouts/modal.tsx, and implemented add assignment modal.

Closes #207

Types of changes


What types of changes does your code introduce?
Put an x in the boxes that apply

  • Bugfix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • Documentation Update (if none of the other choices apply)

Checklist


Put an x in the boxes that apply. You can also fill these out after creating the PR. If you're unsure about any of
them, don't hesitate to ask. This is simply a reminder of what we are going to look for before merging your code.

  • My changeset covers only what is described above (no extraneous changes)
  • Lint and unit tests pass locally with my changes
  • I have added tests that prove my fix is effective or that my feature works
  • I have added necessary documentation (if appropriate)

Further comments


If this is a relatively large or complex change, kick off the discussion by explaining why you chose the solution you
did and what alternatives you considered, etc...

@NeemZ16 NeemZ16 linked an issue Mar 3, 2025 that may be closed by this pull request
@NeemZ16 NeemZ16 marked this pull request as draft March 3, 2025 21:46
@NeemZ16 NeemZ16 self-assigned this Mar 3, 2025
@NeemZ16 NeemZ16 added the client label Mar 3, 2025
@NeemZ16 NeemZ16 changed the title created blank AddAssignmentModal in assignmentFormPage - 41 #41 - Implement add assignment modal Mar 5, 2025
@NeemZ16 NeemZ16 marked this pull request as ready for review March 5, 2025 20:20
@dvcabiya
Copy link
Contributor

dvcabiya commented Mar 7, 2025

Looks great

@dvcabiya dvcabiya merged commit bcf7677 into develop Mar 7, 2025
@dvcabiya dvcabiya deleted the 41-add-assignment-modal branch March 7, 2025 17:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Update add assignment to modal according to Figma

3 participants