Skip to content

Conversation

@dvcabiya
Copy link
Contributor

@dvcabiya dvcabiya commented Apr 1, 2025

Proposed changes


Added support for having just one answer (checkbox/radio inputs) for assignment problems. Added new custom icon for checkboxes, and added behavior for clearing formdata on modal close.

Extraneous:

  • Added the formdata clearing step to other two modals
  • Added a "createdAt" item to formData on NCAG-based questions and their respective NCAGs to make questions with duplicate names render properly while metadata string is being updated

Types of changes


What types of changes does your code introduce?
Put an x in the boxes that apply

  • Bugfix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • Documentation Update (if none of the other choices apply)

Checklist


Put an x in the boxes that apply. You can also fill these out after creating the PR. If you're unsure about any of
them, don't hesitate to ask. This is simply a reminder of what we are going to look for before merging your code.

  • My changeset covers only what is described above (no extraneous changes)
  • Lint and unit tests pass locally with my changes
  • I have added tests that prove my fix is effective or that my feature works
  • I have added necessary documentation (if appropriate)

Further comments


If this is a relatively large or complex change, kick off the discussion by explaining why you chose the solution you
did and what alternatives you considered, etc...

@dvcabiya dvcabiya marked this pull request as ready for review April 1, 2025 19:01
@dvcabiya dvcabiya marked this pull request as draft April 1, 2025 19:02
@dvcabiya dvcabiya marked this pull request as ready for review April 2, 2025 14:45
@dvcabiya dvcabiya merged commit 3e95525 into develop Apr 5, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants