Sprint 1 pull request#52
Merged
jessehartloff merged 209 commits intomainfrom Feb 18, 2024
Merged
Conversation
Adds codeowners and issue templates to add some more structure to the process.
* Adds initial unit testing and mock utilities
Adds codeowners and issue templates to add some more structure to the process.
* Shifting dependencies from devDependencies to dependencies * Update tsconfig to ignore jest
- Support outputting declarations for the build - Move build directory to root directory
- Deleted existing shared modules - installed shared module package - Updated readme with shared module info
Implemented initial developer auth + SAML flows for authentication, uses JWT for tokens Co-authored-by: Michael Drewitt <mikedrewitt@gmail.com>
Added webpack configuration option to allow system env vars to overwrite any options in the env files
Created logout router, controller, and tests. Endpoint unsets `refreshToken` cookie
* Updated README to included actual developer documentation * Implemented the logout button
* All base pages have been created under components/pages * Moved all existing routes into authenticated router
Added logic to checking if dark mode is enabled using the following criteria * local storage * os level theme * defaults to light theme Co-authored-by: Michael Drewitt <mikedrewitt@gmail.com>
* Some minor redux refactors (useSelect rather than mapState) * Navigation bar and links implemented * Made page header a link
* Added checkbox component * Added radio buttons (list) component
* Added assignment types * Added course types Co-authored-by: Joey <j03ypoblete@gmail.com> Co-authored-by: Jesse Hartloff <hartloff@buffalo.edu>
* Added Courses MVC * Added Assignments MVC * Fixed some typeos in existing test suite * Added before/after custom date validator for express-validator Co-authored-by: Michael Drewitt <mikedrewitt@gmail.com> Co-authored-by: Jesse Hartloff <hartloff@buffalo.edu> Co-authored-by: Nick Brown <50608130+bicknrown@users.noreply.github.com> Co-authored-by: Joey <j03ypoblete@gmail.com>
* Add UserCourse types Co-authored-by: Jesse Hartloff <hartloff@buffalo.edu> Co-authored-by: Michael Drewitt <mikedrewitt@gmail.com>
…onForm Add assignment problem creation form
Display Courses and Assignments
Add support for file uploads
Shared modules
-Rename web service to api -remove .github from dockerignore since the directory was moved anyway
-Move all entities to the entities directory
Cleanup the repo
jessehartloff
approved these changes
Feb 18, 2024
Member
jessehartloff
left a comment
jessehartloff
left a comment
There was a problem hiding this comment.
All code has been reviewed in separate PRs. Merging into main
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
20 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Proposed changes
For the Sprint 1, we have implemented several API entities as well as Client Display.
For the entities, we got ContainerAuotGrader, NonContainerAutoGrader, SwaggerTesting, and FileUpload. ContainerAutoGrader will accept some code submissions or submissions that need to be executed in a separate environment. NonContainerAutoGrader will accept submissions that can be graded soon such as attendance codes. This returns assignmentID, question, and score of the question in response. FileUpload handles file upload to minio Cilent and returns the filename, etags, and original filename in response. For the Swagger Testing tool, it is a convenient tool for developer to testing their existing function without building tests from the ground.
For the Client Side, we now can create and display Courses. Creating a Course needs several inputs: Course Name, Course Number, Semester, and Duration of the course.
The issues we have complete are: #42, #48, #37, #21, #17, and #26
Types of changes
What types of changes does your code introduce?
Put an
xin the boxes that applyChecklist
Put an
xin the boxes that apply. You can also fill these out after creating the PR. If you're unsure about any ofthem, don't hesitate to ask. This is simply a reminder of what we are going to look for before merging your code.
Further comments
If this is a relatively large or complex change, kick off the discussion by explaining why you chose the solution you
did and what alternatives you considered, etc...