Skip to content

Migration run fix#61

Merged
jessehartloff merged 2 commits intomakeopensource:developfrom
RA341:migration-run-fix
Mar 1, 2024
Merged

Migration run fix#61
jessehartloff merged 2 commits intomakeopensource:developfrom
RA341:migration-run-fix

Conversation

@RA341
Copy link
Copy Markdown
Collaborator

@RA341 RA341 commented Mar 1, 2024

Proposed changes


Since we had to manually change the hosts envoirment.ts to do stuff.

I added an environment variable to docker-compose in the API called dev:0, this will help us detect if the environment is running on the local machine or in docker.

The value of the dev env variable is irrelevant since we only need to detect if the dev env var exists or not.

This also allows any existing or future files to detect if something is running in docker or locally.

Types of changes


What types of changes does your code introduce?
Put an x in the boxes that apply

  • Bugfix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • Documentation Update (if none of the other choices apply)

Checklist


Put an x in the boxes that apply. You can also fill these out after creating the PR. If you're unsure about any of
them, don't hesitate to ask. This is simply a reminder of what we are going to look for before merging your code.

  • My changeset covers only what is described above (no extraneous changes)
  • Lint and unit tests pass locally with my changes
  • I have added tests that prove my fix is effective or that my feature works
  • I have added necessary documentation (if appropriate)

Further comments


Copy link
Copy Markdown
Member

@jessehartloff jessehartloff left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good idea! Much better than constantly swapping out lines of code

@jessehartloff jessehartloff merged commit ab0a19b into makeopensource:develop Mar 1, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants