Migration run fix#61
Merged
jessehartloff merged 2 commits intomakeopensource:developfrom Mar 1, 2024
Merged
Conversation
jessehartloff
approved these changes
Mar 1, 2024
Member
jessehartloff
left a comment
There was a problem hiding this comment.
Good idea! Much better than constantly swapping out lines of code
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Proposed changes
Since we had to manually change the hosts
envoirment.tsto do stuff.I added an environment variable to docker-compose in the API called
dev:0, this will help us detect if the environment is running on the local machine or in docker.The value of the dev env variable is irrelevant since we only need to detect if the
devenv var exists or not.This also allows any existing or future files to detect if something is running in docker or locally.
Types of changes
What types of changes does your code introduce?
Put an
xin the boxes that applyChecklist
Put an
xin the boxes that apply. You can also fill these out after creating the PR. If you're unsure about any ofthem, don't hesitate to ask. This is simply a reminder of what we are going to look for before merging your code.
Further comments