Skip to content

[WEB-8510] fix(web): fix clipped/overlapping LayoutDropDown button in Create View modal - #9542

Merged
sriramveeraghanta merged 1 commit into
previewfrom
WEB-8510/view-fixes-safari
Aug 4, 2026
Merged

[WEB-8510] fix(web): fix clipped/overlapping LayoutDropDown button in Create View modal#9542
sriramveeraghanta merged 1 commit into
previewfrom
WEB-8510/view-fixes-safari

Conversation

@codingwolf-at

@codingwolf-at codingwolf-at commented Aug 4, 2026

Copy link
Copy Markdown
Contributor

Description

LayoutDropDown (used for the layout selector in the "Create/Update View" modal) was styled with getIconButtonStyling, which is built for icon-only buttons — it forces a fixed square shape (aspect-square + a fixed size-7). Since this dropdown's button renders an icon and a text label ("List", "Board", etc.), the label got clipped (e.g. "List" rendered as "Lis") and the button visually overlapped the adjacent "Display" button.

Fix: use getButtonStyling instead — the same helper already used by comparable text+icon dropdown triggers elsewhere in the codebase (e.g. ProjectOrderByDropdown), which gives a fixed height with auto width instead of a forced square.

Type of Change

  • Bug fix (non-breaking change which fixes an issue)
  • Feature (non-breaking change which adds functionality)
  • Improvement (change that would cause existing functionality to not work as expected)
  • Code refactoring
  • Performance improvements
  • Documentation update

Screenshots and Media (if applicable)

Before: "List" label clipped to "Lis", overlapping the "Display" button.
Screenshot 2026-08-04 at 5 44 01 PM

After: button renders at full width with the complete "List" label and proper spacing.
Screenshot 2026-08-04 at 5 48 56 PM

Test Scenarios

Reproduced and verified in a local dev instance:

  1. Opened Project → Views → "Add view" to bring up the "Create View" modal.
  2. Confirmed the layout dropdown button previously clipped its label and overlapped the neighboring "Display" button.
  3. Applied the fix and re-opened the modal — button now renders at correct width with the full "List" label, no overlap.

References

WEB-8510

Replaced the icon button styling with a more generic button styling for the dropdown component to ensure consistency across the UI. This change enhances the visual coherence of the dropdown button's appearance.
@coderabbitai

coderabbitai Bot commented Aug 4, 2026

Copy link
Copy Markdown
Contributor

Review Change Stack

📝 Walkthrough

Walkthrough

The dropdown layout replaces icon-button styling with the standard secondary large button styling utility.

Changes

Dropdown styling

Layer / File(s) Summary
Apply standard dropdown button styling
apps/web/core/components/dropdowns/layout.tsx
The dropdown imports getButtonStyling and applies getButtonStyling("secondary", "lg") to the button container.

Estimated code review effort: 1 (Trivial) | ~2 minutes

Suggested reviewers: sriramveeraghanta

🚥 Pre-merge checks | ✅ 5
✅ Passed checks (5 passed)
Check name Status Explanation
Docstring Coverage ✅ Passed No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check.
Linked Issues check ✅ Passed Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check ✅ Passed Check skipped because no linked issues were found for this pull request.
Title check ✅ Passed The title clearly identifies the layout dropdown button fix and the affected Create View modal.
Description check ✅ Passed The description explains the cause and fix, marks the bug-fix type, includes screenshots, test scenarios, and a reference.
✨ Finishing Touches
📝 Generate docstrings
  • Create stacked PR
  • Commit on current branch
🧪 Generate unit tests (beta)
  • Create PR with unit tests
  • Commit unit tests in branch WEB-8510/view-fixes-safari

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands.

@github-actions

github-actions Bot commented Aug 4, 2026

Copy link
Copy Markdown

React Doctor found no new issues. 🎉

Reviewed by React Doctor for commit 8026a7c.

@codingwolf-at codingwolf-at changed the title fix(web): update button styling in LayoutDropDown component [WEB-8510] fix(web): fix clipped/overlapping LayoutDropDown button in Create View modal Aug 4, 2026
@makeplane

makeplane Bot commented Aug 4, 2026

Copy link
Copy Markdown

Linked to Plane Work Item(s)

This comment was auto-generated by Plane

@sriramveeraghanta
sriramveeraghanta merged commit c5951e7 into preview Aug 4, 2026
15 checks passed
@sriramveeraghanta
sriramveeraghanta deleted the WEB-8510/view-fixes-safari branch August 4, 2026 14:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants