feat(collector): fallback to any probe if anchor gone (#3569)#3570
Merged
bgm-malbeclabs merged 1 commit intomainfrom Apr 23, 2026
Merged
feat(collector): fallback to any probe if anchor gone (#3569)#3570bgm-malbeclabs merged 1 commit intomainfrom
bgm-malbeclabs merged 1 commit intomainfrom
Conversation
ben-dz
approved these changes
Apr 23, 2026
3 tasks
nikw9944
added a commit
that referenced
this pull request
Apr 23, 2026
…nresponsive (#3576) ## Summary - Fixes the "No responsive probes found for location: slc" error where a location goes dark even though non-anchor probes are available - Adds `fetchFallbackProbesForUnresponsiveLocations` in `configureMeasurements`, called before `generateWantedMeasurements`, which detects locations where all known probes are unresponsive and fetches non-anchor Connected probes as a replacement ## Context PR #3570 added a fallback in `fetchProbesWithErrorHandling` that retries without `is_anchor=true` when the RIPE Atlas API returns zero anchors. That handles the "no anchors in area" case but misses the more common failure mode: RIPE Atlas still reports the anchor as `Connected` (so the API returns it), but the probe has stopped responding to our measurements and was marked unresponsive in the local measurement state. When `generateWantedMeasurements` runs `filterResponsiveProbes`, the anchor is excluded and the location is skipped with no fallback. ## Test plan - [x] Two new unit tests: fallback triggered when all probes unresponsive, no fallback when at least one is responsive - [x] Full `ripeatlas` package tests pass - [x ] Deploy snapshot to devnet and verify SLC measurements are created using non-anchor probes
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary of Changes
Probes were failing for SLC so this PR enables fallback logic to non-anchor probes in the even the probes are not available.
Identifying Probe Issue
To resolve: anchor-preferred with non-anchor fallback, pushed on bgm/ripe-atlas-anchor-fallback.
Closes #3569
Testing Verification