Conversation
…nown probes are unresponsive fetchProbesWithErrorHandling already falls back to non-anchor probes when RIPE Atlas returns no anchors for a location. But when an anchor exists and RIPE Atlas still reports it as Connected, it is returned by the API and fetchProbesWithErrorHandling never falls back — even if that probe has been marked unresponsive in the local measurement state. Add fetchFallbackProbesForUnresponsiveLocations, called in configureMeasurements before generateWantedMeasurements, which detects locations where all known probes are unresponsive and fetches non-anchor Connected probes as a replacement. This fixes the "No responsive probes found for location: slc" log that prevents measurements from being created.
bgm-malbeclabs
approved these changes
Apr 23, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
fetchFallbackProbesForUnresponsiveLocationsinconfigureMeasurements, called beforegenerateWantedMeasurements, which detects locations where all known probes are unresponsive and fetches non-anchor Connected probes as a replacementContext
PR #3570 added a fallback in
fetchProbesWithErrorHandlingthat retries withoutis_anchor=truewhen the RIPE Atlas API returns zero anchors. That handles the "no anchors in area" case but misses the more common failure mode: RIPE Atlas still reports the anchor asConnected(so the API returns it), but the probe has stopped responding to our measurements and was marked unresponsive in the local measurement state. WhengenerateWantedMeasurementsrunsfilterResponsiveProbes, the anchor is excluded and the location is skipped with no fallback.Test plan
ripeatlaspackage tests pass🤖 Generated with Claude Code