Skip to content

cli: show multicast group codes in feed list - #4150

Merged
bgm-malbeclabs merged 2 commits into
mainfrom
cli-feed-list-group-codes
Aug 5, 2026
Merged

cli: show multicast group codes in feed list#4150
bgm-malbeclabs merged 2 commits into
mainfrom
cli-feed-list-group-codes

Conversation

@bgm-malbeclabs

Copy link
Copy Markdown
Contributor

Resolves: malbeclabs/infra#2172

Summary of Changes

  • doublezero feed list gains a group_codes column naming the multicast groups the feed holds, so the list answers "what's in this feed?" without a follow-up feed get plus manual pubkey lookups.
  • Groups are resolved to codes via one list_multicastgroup call; a group the ledger no longer carries falls back to its raw pubkey, matching how accesspass list renders its allowlists.
  • The existing groups count column is unchanged, and the JSON output gains the new field (additive — existing consumers that decode a field subset, including the feed_crud e2e test, are unaffected).

Diff Breakdown

Category Files Lines (+/-) Net
Core logic 1 +17 / -1 +16
Tests 1 +75 / -0 +75
Docs 1 +3 / -0 +3
Total 2 +95 / -1 +94

A one-column display change; most of the diff is the new list test.

Key files (click to expand)
  • smartcontract/cli/src/feed/list.rs — adds the group_codes field to FeedDisplay, resolves group pubkeys to codes with a pubkey fallback, and adds test_cli_feed_list covering both the resolved and unknown-group paths
  • CHANGELOG.md — Unreleased / Changes entry under CLI

Testing Verification

  • New test_cli_feed_list asserts the rendered table carries the column and that a feed holding one known and one unknown group renders mg01, 11111115q4Ep… — the code for the resolved group, the raw pubkey for the other.
  • Rendered output confirmed by hand: account | code | name | exchange | groups | group_codes | owner.
  • cargo test -p doublezero-serviceability-cli feed:: — 34 passing.

Resolves the feed's group pubkeys to multicast group codes and renders them in
a new group_codes column, falling back to the raw pubkey when a group is not
found.

Closes malbeclabs/infra#2172
@bgm-malbeclabs
bgm-malbeclabs force-pushed the cli-feed-list-group-codes branch from e9b2535 to 8992358 Compare August 5, 2026 00:54
Comment thread smartcontract/cli/src/feed/list.rs Outdated
Comment thread smartcontract/cli/src/feed/list.rs Outdated
@bgm-malbeclabs
bgm-malbeclabs enabled auto-merge (squash) August 5, 2026 01:07
@bgm-malbeclabs
bgm-malbeclabs merged commit 77d57d2 into main Aug 5, 2026
37 checks passed
@bgm-malbeclabs
bgm-malbeclabs deleted the cli-feed-list-group-codes branch August 5, 2026 01:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants