cli: show multicast group codes in feed list - #4150
Merged
Merged
Conversation
Resolves the feed's group pubkeys to multicast group codes and renders them in a new group_codes column, falling back to the raw pubkey when a group is not found. Closes malbeclabs/infra#2172
bgm-malbeclabs
force-pushed
the
cli-feed-list-group-codes
branch
from
August 5, 2026 00:54
e9b2535 to
8992358
Compare
martinsander00
approved these changes
Aug 5, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Resolves: malbeclabs/infra#2172
Summary of Changes
doublezero feed listgains agroup_codescolumn naming the multicast groups the feed holds, so the list answers "what's in this feed?" without a follow-upfeed getplus manual pubkey lookups.list_multicastgroupcall; a group the ledger no longer carries falls back to its raw pubkey, matching howaccesspass listrenders its allowlists.groupscount column is unchanged, and the JSON output gains the new field (additive — existing consumers that decode a field subset, including thefeed_crude2e test, are unaffected).Diff Breakdown
A one-column display change; most of the diff is the new list test.
Key files (click to expand)
smartcontract/cli/src/feed/list.rs— adds thegroup_codesfield toFeedDisplay, resolves group pubkeys to codes with a pubkey fallback, and addstest_cli_feed_listcovering both the resolved and unknown-group pathsCHANGELOG.md— Unreleased / Changes entry under CLITesting Verification
test_cli_feed_listasserts the rendered table carries the column and that a feed holding one known and one unknown group rendersmg01, 11111115q4Ep…— the code for the resolved group, the raw pubkey for the other.account | code | name | exchange | groups | group_codes | owner.cargo test -p doublezero-serviceability-cli feed::— 34 passing.