Skip to content

e2e/qa: name the gate for instant_allocation_price, not a version #4166

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
bgm-malbeclabs merged 1 commit into from
Aug 7, 2026
+9 −6
Merged

e2e/qa: name the gate for instant_allocation_price, not a version #4166

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 3 additions & 0 deletions CHANGELOG.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -8,6 +8,9 @@ All notable changes to this project will be documented in this file.

### Changes

- E2E/QA
- `TestQA_MulticastSettlement`'s `validate_instant_allocation_price_matches_chain` no longer names a specific `doublezero_solana_version` in its skip path. Both the comment and the skip message said the pin was `0.5.10-1`; testnet has since moved to `0.5.11-1`, so a reader was told the pin was merely behind when in fact `instant_allocation_price` is in no release yet. They now name what actually gates the field — a doublezero-offchain release carrying doublezero-offchain#405 — and where the pin lives, neither of which goes stale as versions move. Comment and message only, no behaviour change.

## [v0.34.0](https://github.com/malbeclabs/doublezero/compare/client/v0.33.0...client/v0.34.0) - 2026-08-07

### Breaking
Expand Down
12 changes: 6 additions & 6 deletions e2e/qa_multicast_settlement_test.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -418,12 +418,12 @@ func TestQA_MulticastSettlement(t *testing.T) {
case !quoted.GetReportsInstantAllocationPrice():
// QA hosts install doublezero-solana from a version-pinned apt package
// (doublezero_solana_version in malbeclabs/infra
// ansible/inventory/*/group_vars/all.yml, 0.5.10-1 at time of writing),
// so the field only appears once a release carrying it is published and
// the pin bumped. Asserting against an absent field would read 0 and
// fail as "quoted 0, chain 43" — a misleading failure that looks like a
// new bug rather than a rollout gap.
t.Skipf("Skipping: installed doublezero-solana does not report instant_allocation_price (needs a release newer than the pinned 0.5.10-1); chain says %d USDC at last_settled_epoch=%d",
// ansible/inventory/<env>/group_vars/all.yml), so the field appears only
// once a doublezero-offchain release carrying it is published and that
// pin is bumped. The column landed in doublezero-offchain#405. Asserting
// against an absent field would read 0 and fail as "quoted 0, chain 43" —
// a misleading failure that looks like a new bug rather than a rollout gap.
t.Skipf("Skipping: installed doublezero-solana does not report instant_allocation_price (needs a release carrying doublezero-offchain#405); chain says %d USDC at last_settled_epoch=%d",
onchain.InstantAllocationDollars, onchain.LastSettledEpoch)
case quoted.InstantAllocationPrice == nil:
// Reported, but null: the CLI could not find the settled-epoch ring
Expand Down
Loading