Skip to content

CD-i: Fix XA Audio Peaking - #14470

Merged
MooglyGuy merged 1 commit into
mamedev:masterfrom
Vincent-Halver:master
Nov 4, 2025
Merged

MooglyGuy merged 1 commit into
mamedev:masterfrom
Vincent-Halver:master

Conversation

@Vincent-Halver

Copy link
Copy Markdown
Contributor

-cdicdic: Fixed audio peaking by decoding in 32-bit and clipping to 16 later. [Vincent Halver]

-cdislavehle: Simplified mouse position-update logic. [Vincent Halver]

-cdicdic: Fixed audio peaking by decoding in 32-bit and clipping to 16 later. [Vincent Halver]

-cdislavehle: Simplified mouse position-update logic. [Vincent Halver]
@MooglyGuy
MooglyGuy merged commit 24faec6 into mamedev:master Nov 4, 2025
Comment on lines +267 to 271
inline void rotate_samples(int16_t val, int16_t& a, int16_t& b, int16_t& output) {
b = a;
a = val;
output = a;
}

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

If this is correct, it’s a confusing way of doing it. Why aren’t you assigning output = val directly? I can’t see a way aliasing could require it to be done like this putting the value through a as an intermediate.

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is correct. You could use output = val; if you prefer.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants