Repository navigation
CD-i: Fix XA Audio Peaking - #14470
Merged
Merged
Conversation
-cdicdic: Fixed audio peaking by decoding in 32-bit and clipping to 16 later. [Vincent Halver] -cdislavehle: Simplified mouse position-update logic. [Vincent Halver]
cuavas
reviewed
Nov 12, 2025
Comment on lines
+267
to
271
| inline void rotate_samples(int16_t val, int16_t& a, int16_t& b, int16_t& output) { | ||
| b = a; | ||
| a = val; | ||
| output = a; | ||
| } |
Member
There was a problem hiding this comment.
If this is correct, it’s a confusing way of doing it. Why aren’t you assigning output = val directly? I can’t see a way aliasing could require it to be done like this putting the value through a as an intermediate.
Contributor
Author
There was a problem hiding this comment.
This is correct. You could use output = val; if you prefer.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
-cdicdic: Fixed audio peaking by decoding in 32-bit and clipping to 16 later. [Vincent Halver]
-cdislavehle: Simplified mouse position-update logic. [Vincent Halver]