Check software parts for incompatibility as well as compatibility

[ajrhacker]

This new softlist feature is now used by genesis_tmss to exclude several entries from megadriv.xml.

• Use popmessage instead of osd_printf_warning for incompatibility warnings
• Unify some common software loading code, which reduces indentation levels in clifront.cpp

[etabeta78]

I've been a little bit out of the loop of how compatibility features are
checked since C++-fication, but I'd like to ask: are the
compatibility/incompatibility flags still only optional and filtering only
turned on when people launches
mame system gamename
right?
because sometimes you want to load incompatible software for debugging
purposes, and thus original behavior was to bypass the checks when launching
mame system -cart gamename

Thanks in advance
f.

On Wed, May 4, 2016 at 5:55 AM, ajrhacker notifications@github.com wrote:

This new softlist feature is now used by genesis_tmss to exclude several
entries from megadriv.xml.

• Use popmessage instead of osd_printf_warning for incompatibility
  warnings
• Unify some common software loading code, which reduces indentation
  levels in clifront.cpp

---

You can view, comment on, or merge this pull request online at:

#854
Commit Summary

• Check software parts for incompatibility as well as compatibility

File Changes

• M hash/megadriv.xml
  https://github.com/mamedev/mame/pull/854/files#diff-0 (5)
• M src/emu/diimage.cpp
  https://github.com/mamedev/mame/pull/854/files#diff-1 (40)
• M src/emu/softlist.cpp
  https://github.com/mamedev/mame/pull/854/files#diff-2 (72)
• M src/emu/softlist.h
  https://github.com/mamedev/mame/pull/854/files#diff-3 (9)
• M src/frontend/mame/clifront.cpp
  https://github.com/mamedev/mame/pull/854/files#diff-4 (44)
• M src/frontend/mame/ui/selsoft.cpp
  https://github.com/mamedev/mame/pull/854/files#diff-5 (2)
• M src/frontend/mame/ui/swlist.cpp
  https://github.com/mamedev/mame/pull/854/files#diff-6 (2)
• M src/mame/drivers/megadriv.cpp
  https://github.com/mamedev/mame/pull/854/files#diff-7 (5)

Patch Links:

• https://github.com/mamedev/mame/pull/854.patch
• https://github.com/mamedev/mame/pull/854.diff

—
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub
#854

[ajrhacker]

I previously suggested, and this time nearly implemented, a command-line option to disable software compatibility checking from the command line. However, I realized that explicitly specifying an image device by interface name already allowed incompatible software to be loaded, so all that I changed regarding that feature is how the warning message for incompatible software gets displayed. (The message also now slightly differs depending on whether it was the check against the "compatibility" feature or the check against the "incompatibility" feature that failed; the latter takes precedence, of course.)

[etabeta78]

The logic was that "casual users" would probably just go the "MAME-way"
when loading home computer/console games and thus they shall not face the
possible black screens due to incompatible regions.
OTOH, adding the media switch (-cart, -cass, etc.) is the solution that
would probably be followed by more experienced users that know what they're
doing and can realize that loading a PAL game in a NTSC system or viceversa
could give unwanted results.

Eventually, we might indeed want to add a command line option for this, but
for the moment this solution seems to have worked well enough :)

f.

On Wed, May 4, 2016 at 6:59 AM, ajrhacker notifications@github.com wrote:

I previously suggested, and this time nearly implemented, a command-line
option to disable software compatibility checking from the command line.
However, I realized that explicitly specifying an image device by interface
name already allowed incompatible software to be loaded, so all that I
changed regarding that feature is how the warning message for incompatible
software gets displayed. (The message also now slightly differs depending
on whether it was the check against the "compatibility" feature or the
check against the "incompatibility" feature that failed; the latter takes
precedence, of course.)

—
You are receiving this because you commented.
Reply to this email directly or view it on GitHub
#854 (comment)