Pin openapi-spec-validator to versions < 0.5.0#43
Merged
manchenkoff merged 2 commits intomanchenkoff:masterfrom Sep 5, 2022
Merged
Conversation
Version 0.5.0 removed some convenience imports used by openapi3-parser, breaking the parsing functionality. This pin can be removed once the package structure is refactored and the missing imports are addressed.
While running 'pipenv install --dev', this updated the lockfile.
Owner
|
Thanks for PR, dependencies in |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #41
Note - this is the first time I'm using pipenv, so I just set up the project with
pipenv install --devwhich functionaly works, but caused the lockfile to be updated. That seems as correct behaviour to me, but depending on which exact minor version of Python you're using, this may lead to ever-changing lock files.I'm also not sure if the package dependencies should be specified in the
Pipfileif they're already present insetup.py- aspip install -e .already takes care of pulling in the dependencies for local development.