Implement skipping strict enums during parsing#44
Merged
manchenkoff merged 2 commits intomanchenkoff:masterfrom Sep 12, 2022
Merged
Conversation
sergei-maertens
commented
Sep 4, 2022
sergei-maertens
commented
Sep 4, 2022
sergei-maertens
commented
Sep 4, 2022
sergei-maertens
commented
Sep 4, 2022
manchenkoff
requested changes
Sep 5, 2022
Owner
There was a problem hiding this comment.
I've left some minor comments. There are still some errors in a build pipeline related to problematic dependency you fixed before, so, please, do the rebase/pull the actual master into your branch
Contributor
Author
|
I'll apply the feedback later this week - probably it will be in the weekend. Thanks for the review! |
sergei-maertens
force-pushed
the
feature/40-loose-enum-validation
branch
from
994f9e6 to
5b7ab7f
Compare
Contributor
Author
|
Rebased on master and PR feedback is processed! |
Certain schema properties (content types, type formats...) are not limited to a known set of values in the OpenAPI 3.x specification. Users can opt-in for non-strict enum evaluation, making it possible to parse specifications with custom content types and/or formats used in schema definitions.
sergei-maertens
force-pushed
the
feature/40-loose-enum-validation
branch
from
5b7ab7f to
f33cb15
Compare
manchenkoff
approved these changes
Sep 12, 2022
Owner
|
@sergei-maertens published in v1.1.6 release, thanks 👍 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #40
Added the
strict_enumflag to the parse function, which is forwarded to the underlying builders. The default value isTrueto keep the current default behaviour.The
Loose<EnumType>classes mimick theEnumAPI through thevalueattribute, so downstream users don't need to check the type ofSchema.formatorContent.type.