[Build] Complete the loadlib relocation out of dep/ - #3
Merged
billy1arm merged 1 commit intoJun 30, 2026
Merged
Conversation
The earlier move of the loadlib reader out of dep/ landed the file move but not the build wiring, leaving the tree unable to configure or compile the extractors (the loadlib target was never defined and stale include paths pointed at the removed dep/loadlib/sl/ location). - dep/CMakeLists.txt: drop the dangling add_subdirectory(loadlib) (the directory no longer lives under dep/) - src/tools/Extractor_projects/CMakeLists.txt: add_subdirectory(loadlib) so the relocated target is actually built - fix four stale includes ../loadlib/sl/X.h -> ../loadlib/X.h (map-extractor System.cpp x2, dbcfile.cpp, shared/ExtractorCommon.h) - update the now-stale dep/loadlib/sl/adt.h reference in a GridMap comment map-extractor, vmap-extractor and mmap-extractor all build again.
This was referenced Jun 30, 2026
H0zen
added a commit
to H0zen/mangos_four
that referenced
this pull request
Aug 4, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The earlier "move loadlib out of
dep/" change landed the file move but not the build wiring, somastercurrently can't configure or compile the extractors:dep/CMakeLists.txtstill ranadd_subdirectory(loadlib)for the now-removeddep/loadlib/, so CMake configure errors out.src/tools/Extractor_projects/CMakeLists.txtwas missing theadd_subdirectory(loadlib)that defines the relocated target — so all three extractors linked an undefinedloadlib(no StormLib include propagation).../loadlib/sl/X.hpath (map-extractor/System.cpp×2,map-extractor/dbcfile.cpp,shared/ExtractorCommon.h).This completes the relocation:
dep/add_subdirectory(loadlib)add_subdirectory(loadlib)in the extractor tree../loadlib/sl/X.h→../loadlib/X.hincludesdep/loadlib/sl/adt.hreference in aGridMapcommentVerified:
map-extractor,vmap-extractor, andmmap-extractorall build green again (MSVC, Release).This change is